Re: snd-soc-cs4270: Convert to a new-style i2c driver (work in progress)

[Timur Tabi <timur@freescale.com>]

Jean Delvare wrote:

> * Your driver now lacks a remove method. Unless I miss something, if
> the snd-soc-cs4270 driver is unloaded, you will leave dangling
> resources behind (codec->reg_cache in particular.)

Indeed, but then, I don't think I ever supported loading and unload this driver
as a module.  The Kconfig does say it's a tristate, though.  I'll take a look at
it.

Most of my real development is going to the ASoC V2 version of this driver, and
that version should be a lot better.  I'll take another look at both driver to
make sure I didn't screw this up.

> * I2C_DRIVERID_CS4270 must be removed from i2c-id.h.

It can't be removed until this patch goes upstream, but thanks for the reminder.

> As I understand it, without that patch the mpc8610_hpcd doesn't work,
> as the I2C address of the sound codec will be made busy by the platform
> code and thus the snd-soc-cs4270 driver won't be able to attach to it.

That's correct.  I though I made that clear in the changelog.

> Do you
> know off the top of your head if other drivers have already been
> converted?

I doubt it.  ASoC V1 doesn't generally support PowerPC, although there is code
to make it work.  That's why there's not a lot of support across the board for
PowerPC-isms.

-- 
Timur Tabi
Linux kernel developer at Freescale