From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KaYHX-000056-Cd for mharc-grub-devel@gnu.org; Tue, 02 Sep 2008 11:59:03 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KaYHV-0008W9-JG for grub-devel@gnu.org; Tue, 02 Sep 2008 11:59:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KaYHU-0008Vo-Pm for grub-devel@gnu.org; Tue, 02 Sep 2008 11:59:01 -0400 Received: from [199.232.76.173] (port=33337 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KaYHU-0008Ve-Jt for grub-devel@gnu.org; Tue, 02 Sep 2008 11:59:00 -0400 Received: from fg-out-1718.google.com ([72.14.220.154]:14299) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KaYHU-0006V3-0q for grub-devel@gnu.org; Tue, 02 Sep 2008 11:59:00 -0400 Received: by fg-out-1718.google.com with SMTP id l26so1608530fgb.30 for ; Tue, 02 Sep 2008 08:58:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=fV4dmllOc9mN5Tv7XoF2OV7HjSyr4DlUNh/XoMDn600=; b=O0f6VkXsbxCKfWSGjytiQDYjJqOXjdfaGw1bJOkjwHZ5NZ8a6+uAuEePfTGcg/qtum pL7rOMDQpZ194yxusUJ8rg4HpeJgzaxJA+JY22Nx16w8tMo2jnvCjYIh6mcWLeFC3xTp eXZjDCYO1ug/+d1QIVXHcAZmz+29neW5Ct56c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=tGriRuOSdGa4GlGqlEOXpp3BZ1IKSKafbIt6LUHtIo7q7lOvkE8vYTRduvG9taQTa0 Bzc7OsMgyWDknpFnbgNlJv8k5xrGjywWVsYATjVr+59mCxT1k4FO95MwTaZdxgQlmbFm rV4vLS3TCX+l47L61qiyI8fWwdzDc/nPCrieg= Received: by 10.86.23.17 with SMTP id 17mr5742007fgw.32.1220371139227; Tue, 02 Sep 2008 08:58:59 -0700 (PDT) Received: from ?192.168.1.15? ( [83.76.170.177]) by mx.google.com with ESMTPS id 4sm8422667fge.8.2008.09.02.08.58.56 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 02 Sep 2008 08:58:58 -0700 (PDT) Message-ID: <48BD62BE.7090507@gmail.com> Date: Tue, 02 Sep 2008 17:58:54 +0200 From: phcoder User-Agent: Thunderbird 2.0.0.16 (X11/20080724) MIME-Version: 1.0 To: The development of GRUB 2 References: <48BD4C52.6040308@gmail.com> <1220367299.23879.15.camel@localhost> In-Reply-To: <1220367299.23879.15.camel@localhost> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) Subject: Re: Sendkey patch X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Sep 2008 15:59:02 -0000 Hello, again I had a look at your patch. In some mail it was suggested that kernel patch should be split from module that uses it. So I resend the kernel part of my patch. Another question is whether we need some kind of abortion procedure (like in your patch) if a preboot hook fails. Javier Martín wrote: > An interface like this is implemented in another patch in "discussion", > my drivemap patch (see the August list archives). As yours, it is > linked-list based and very similar in the prototypes. I haven't checked > if your code has any kind of errors/corner cases, I checked and found that I didn't check if grub_malloc succeeded > but it seems terser > than mine even though it's a bit more difficult to understand because > you use double pointers to avoid my handling of the head case. I don't > understand the purpose of doubly-linking the list though... > The goal is to avoid walking through list when deleting an entry from it. >> Whether we need also interface for adding "postboot" commands? (in case >> boot_function returns) > I don't think it would offer a lot of functionality because most loaders > don't return on failure, they just get stuck or their payload > triple-faults and reboots. It's the case for i386-pc loaders but not the case of some other targets (e.g. EFI). So the question remains. Vladimir Serbinenko