From: "Jan Beulich" <jbeulich@novell.com>
To: "David S. Miller" <davem@davemloft.net>,
"Ingo Molnar" <mingo@elte.hu>,
"Ivo van Doorn" <IvDoorn@gmail.com>,
"Boaz Harrosh" <bharrosh@panasas.com>,
"Rusty Russell" <rusty@rustcorp.com.au>,
"John W. Linville" <linville@tuxdriver.com>
Cc: "Alexey Dobriyan" <adobriyan@gmail.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Theodore Tso" <tytso@mit.edu>,
"linux-kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5 ver2] debug: BUILD_BUG_ON: error on non-const expressions
Date: Tue, 02 Sep 2008 17:11:00 +0100 [thread overview]
Message-ID: <48BD81B4.76E4.0078.0@novell.com> (raw)
In-Reply-To: <48BD626B.6070705@panasas.com>
>>> Boaz Harrosh <bharrosh@panasas.com> 02.09.08 17:57 >>>
>-#define BUILD_BUG_ON_ZERO(e) (sizeof(char[1 - 2 * !!(e)]) - 1)
>+#define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:-!!(e); }))
>+
>+/* Force a compilation error if condition is true */
>+#define BUILD_BUG_ON(e) \
>+ do { struct {int:-!!(e); } x __maybe_unused;} while(0)
As indicated before, you should at the very least use __x as the variable
name.
But didn't you have reservations against using a bitfield here? Or was it
really just the void cast on the sizeof() that you disliked?
Jan
next prev parent reply other threads:[~2008-09-02 16:09 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 13:00 [PATCHSET 0/5] BUILD_BUG_ON: error on none-const expressions Boaz Harrosh
2008-09-01 13:07 ` [PATCH] debug, x86: move BUILD_BUG_ON() ARRAY_SIZE and __FUNCTION__ Boaz Harrosh
2008-09-01 13:11 ` [PATCH 2/5] net/niu: Fix none-const BUILD_BUG_ON usage Boaz Harrosh
2008-09-01 13:13 ` [PATCH 3/5] virtio: " Boaz Harrosh
2008-09-02 15:53 ` [PATCH 3/5 ver2] virtio: Fix non-const " Boaz Harrosh
2008-09-01 13:21 ` [PATCH 4/5] rt2x00: Compiler warning unmasked by fix of BUILD_BUG_ON Boaz Harrosh
2008-09-01 13:27 ` Ivo Van Doorn
2008-09-01 13:27 ` Benny Halevy
2008-09-01 13:44 ` [PATCH 4/5 ver2] " Boaz Harrosh
2008-09-01 14:01 ` Ivo Van Doorn
2008-09-01 15:17 ` Boaz Harrosh
2008-09-01 16:34 ` Ivo van Doorn
2008-09-02 14:20 ` Boaz Harrosh
2008-09-02 14:27 ` Ivo van Doorn
2008-09-02 15:55 ` Boaz Harrosh
2008-09-01 13:28 ` [PATCH 5/5] debug: BUILD_BUG_ON: error on non-const expressions Boaz Harrosh
2008-09-01 13:55 ` Jan Beulich
2008-09-01 14:21 ` Boaz Harrosh
2008-09-01 14:36 ` Jan Beulich
2008-09-01 15:00 ` Boaz Harrosh
2008-09-01 15:29 ` Jan Beulich
2008-09-01 16:41 ` Boaz Harrosh
2008-09-02 7:47 ` Jan Beulich
2008-09-02 15:19 ` Boaz Harrosh
2008-09-02 15:57 ` [PATCH 5/5 ver2] " Boaz Harrosh
2008-09-02 16:06 ` Boaz Harrosh
2008-09-02 16:11 ` Jan Beulich [this message]
2008-09-03 8:57 ` Boaz Harrosh
2008-09-03 10:19 ` Jan Beulich
2008-09-03 10:52 ` Boaz Harrosh
2008-10-02 5:35 ` Rusty Russell
2008-10-05 9:34 ` Boaz Harrosh
2008-09-02 16:07 ` [PATCH 5/5 ver3] " Boaz Harrosh
2008-09-06 16:01 ` [PATCHSET 0/5] BUILD_BUG_ON: error on none-const expressions Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48BD81B4.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=IvDoorn@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bharrosh@panasas.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.