From: Randy Dunlap <randy.dunlap@oracle.com>
To: linux-ide@vger.kernel.org, linux-next@vger.kernel.org
Cc: akpm <akpm@linux-foundation.org>, bzolnier@gmail.com
Subject: [PATCH -next] ide: fix Makefile for ide-disk_proc
Date: Tue, 02 Sep 2008 11:44:54 -0700 [thread overview]
Message-ID: <48BD89A6.1040200@oracle.com> (raw)
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix ide-disk_proc build error due to 2 entries in Makefile, one of them
being unconditional.
When CONFIG_IDE_PROC_FS=n, there are lots of errors/warnings:
linux-next-20080902/drivers/ide/ide-disk_proc.c:100: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'ide_disk_proc'
linux-next-20080902/drivers/ide/ide-disk_proc.c:109: warning: data definition has no type or storage class
linux-next-20080902/drivers/ide/ide-disk_proc.c:109: warning: type defaults to 'int' in declaration of 'ide_devset_rw_field'
linux-next-20080902/drivers/ide/ide-disk_proc.c:109: warning: parameter names (without types) in function declaration
linux-next-20080902/drivers/ide/ide-disk_proc.c:110: warning: data definition has no type or storage class
linux-next-20080902/drivers/ide/ide-disk_proc.c:110: warning: type defaults to 'int' in declaration of 'ide_devset_rw_field'
linux-next-20080902/drivers/ide/ide-disk_proc.c:110: warning: parameter names (without types) in function declaration
linux-next-20080902/drivers/ide/ide-disk_proc.c:111: warning: data definition has no type or storage class
linux-next-20080902/drivers/ide/ide-disk_proc.c:111: warning: type defaults to 'int' in declaration of 'ide_devset_rw_field'
linux-next-20080902/drivers/ide/ide-disk_proc.c:111: warning: parameter names (without types) in function declaration
linux-next-20080902/drivers/ide/ide-disk_proc.c:112: warning: data definition has no type or storage class
linux-next-20080902/drivers/ide/ide-disk_proc.c:112: warning: type defaults to 'int' in declaration of 'ide_devset_rw_field'
linux-next-20080902/drivers/ide/ide-disk_proc.c:112: warning: parameter names (without types) in function declaration
linux-next-20080902/drivers/ide/ide-disk_proc.c:113: warning: data definition has no type or storage class
linux-next-20080902/drivers/ide/ide-disk_proc.c:113: warning: type defaults to 'int' in declaration of 'ide_devset_rw_field'
linux-next-20080902/drivers/ide/ide-disk_proc.c:113: warning: parameter names (without types) in function declaration
linux-next-20080902/drivers/ide/ide-disk_proc.c:114: warning: data definition has no type or storage class
linux-next-20080902/drivers/ide/ide-disk_proc.c:114: warning: type defaults to 'int' in declaration of 'ide_devset_rw_field'
linux-next-20080902/drivers/ide/ide-disk_proc.c:114: warning: parameter names (without types) in function declaration
linux-next-20080902/drivers/ide/ide-disk_proc.c:116: error: array type has incomplete element type
linux-next-20080902/drivers/ide/ide-disk_proc.c:117: error: implicit declaration of function 'IDE_PROC_DEVSET'
linux-next-20080902/drivers/ide/ide-disk_proc.c:117: error: 'acoustic' undeclared here (not in a function)
linux-next-20080902/drivers/ide/ide-disk_proc.c:118: error: 'address' undeclared here (not in a function)
linux-next-20080902/drivers/ide/ide-disk_proc.c:119: error: 'bios_cyl' undeclared here (not in a function)
linux-next-20080902/drivers/ide/ide-disk_proc.c:120: error: 'bios_head' undeclared here (not in a function)
linux-next-20080902/drivers/ide/ide-disk_proc.c:121: error: 'bios_sect' undeclared here (not in a function)
linux-next-20080902/drivers/ide/ide-disk_proc.c:122: error: 'failures' undeclared here (not in a function)
linux-next-20080902/drivers/ide/ide-disk_proc.c:123: error: 'lun' undeclared here (not in a function)
linux-next-20080902/drivers/ide/ide-disk_proc.c:124: error: 'max_failures' undeclared here (not in a function)
linux-next-20080902/drivers/ide/ide-disk_proc.c:125: error: 'multcount' undeclared here (not in a function)
linux-next-20080902/drivers/ide/ide-disk_proc.c:126: error: 'nowerr' undeclared here (not in a function)
linux-next-20080902/drivers/ide/ide-disk_proc.c:127: error: 'wcache' undeclared here (not in a function)
make[3]: *** [drivers/ide/ide-disk_proc.o] Error 1
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/ide/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20080902.orig/drivers/ide/Makefile
+++ linux-next-20080902/drivers/ide/Makefile
@@ -36,7 +36,7 @@ obj-$(CONFIG_IDE_H8300) += h8300/
obj-$(CONFIG_IDE_GENERIC) += ide-generic.o
obj-$(CONFIG_BLK_DEV_IDEPNP) += ide-pnp.o
-ide-disk_mod-y += ide-disk.o ide-disk_ioctl.o ide-disk_proc.o
+ide-disk_mod-y += ide-disk.o ide-disk_ioctl.o
ide-cd_mod-y += ide-cd.o ide-cd_ioctl.o ide-cd_verbose.o
ide-floppy_mod-y += ide-floppy.o ide-floppy_ioctl.o
next reply other threads:[~2008-09-02 18:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-02 18:44 Randy Dunlap [this message]
2008-09-02 18:47 ` [PATCH -next] ide: fix Makefile for ide-disk_proc Bartlomiej Zolnierkiewicz
2008-09-02 18:53 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48BD89A6.1040200@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.