From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Hofman Subject: Re: [PATCH] add the nvidia HDMI codec driver for MCP77/79 Date: Wed, 03 Sep 2008 14:11:16 +0200 Message-ID: <48BE7EE4.8020800@insite.cz> References: <200809031558156739794@gmail.com> <15F501D1A78BD343BE8F4D8DB854566B31F8F744@hkemmail01.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from server.insite.cz (cable.insite.cz [84.242.84.93]) by alsa0.perex.cz (Postfix) with ESMTP id ED38E245A4 for ; Thu, 4 Sep 2008 08:32:58 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: Peer Chen , Wei Ni , alsa-devel , akpm , linux-kernel List-Id: alsa-devel@alsa-project.org >> ...... >> According to these codes, It only can get the realtek codec and can not >> get hdmi codec, if just change azx_max_codecs[AZX_DRIVER_NVIDIA] to 4 >> I think if remove "if (!audio_codecs)", it will be better, and I only >> need to chang azx_max_codecs[AZX_DRIVER_NVIDIA] to 4 > > Well, the check is there for a good reason. > > There are many machines with broken BIOS reporting the 4th slot > available although it isn't actually. It's a workaround to skip such > a bogus information. So, it cannot be changed so easily. > > We need to sort out this in a better way... Oh well. Please, please, put the above information as a comment to the respective place. These "hacks" should be commented :) Thanks a lot, Pavel. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754893AbYIDGvt (ORCPT ); Thu, 4 Sep 2008 02:51:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751205AbYIDGvl (ORCPT ); Thu, 4 Sep 2008 02:51:41 -0400 Received: from cable.insite.cz ([84.242.84.93]:35689 "EHLO server.insite.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750870AbYIDGvk (ORCPT ); Thu, 4 Sep 2008 02:51:40 -0400 X-Greylist: delayed 1114 seconds by postgrey-1.27 at vger.kernel.org; Thu, 04 Sep 2008 02:51:40 EDT Message-ID: <48BE7EE4.8020800@insite.cz> Date: Wed, 03 Sep 2008 14:11:16 +0200 From: Pavel Hofman User-Agent: Thunderbird 2.0.0.16 (X11/20080724) MIME-Version: 1.0 To: Takashi Iwai CC: Wei Ni , Peer Chen , alsa-devel , linux-kernel , akpm Subject: Re: [alsa-devel] [PATCH] add the nvidia HDMI codec driver for MCP77/79 References: <200809031558156739794@gmail.com> <15F501D1A78BD343BE8F4D8DB854566B31F8F744@hkemmail01.nvidia.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> ...... >> According to these codes, It only can get the realtek codec and can not >> get hdmi codec, if just change azx_max_codecs[AZX_DRIVER_NVIDIA] to 4 >> I think if remove "if (!audio_codecs)", it will be better, and I only >> need to chang azx_max_codecs[AZX_DRIVER_NVIDIA] to 4 > > Well, the check is there for a good reason. > > There are many machines with broken BIOS reporting the 4th slot > available although it isn't actually. It's a workaround to skip such > a bogus information. So, it cannot be changed so easily. > > We need to sort out this in a better way... Oh well. Please, please, put the above information as a comment to the respective place. These "hacks" should be commented :) Thanks a lot, Pavel.