From: Jeff Garzik <jeff@garzik.org>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
akpm@linux-foundation.org,
Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: [NET-NEXT PATCH 01/13] ixgbe: fix rx csum return status misinterpretation
Date: Wed, 03 Sep 2008 10:03:51 -0400 [thread overview]
Message-ID: <48BE9947.4060703@garzik.org> (raw)
In-Reply-To: <20080826112656.15787.38277.stgit@jtkirshe-mobile.jf.intel.com>
Jeff Kirsher wrote:
> From: Jesse Brandeburg <jesse.brandeburg@intel.com>
>
> the driver was misinterpreting rx_csum return value in the descriptor
> so occassionally we would indicate an rx_csum error in our stats
> when there was none. This would have no effect on traffic because
> we would just hand the packet to the stack anyway without the offload
> flag set, but would increase CPU for those packets that needed a recompute.
>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> ---
>
> drivers/net/ixgbe/ixgbe_main.c | 8 +++-----
> 1 files changed, 3 insertions(+), 5 deletions(-)
applied 1-13
prev parent reply other threads:[~2008-09-03 14:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 11:26 [NET-NEXT PATCH 01/13] ixgbe: fix rx csum return status misinterpretation Jeff Kirsher
2008-08-26 11:26 ` [NET-NEXT PATCH 02/13] ixgbe: add little endian annotations for sparse Jeff Kirsher
2008-08-26 11:27 ` [NET-NEXT PATCH 03/13] ixgbe: Implement HAVE_SET_RX_MODE Jeff Kirsher
2008-08-26 11:27 ` [NET-NEXT PATCH 04/13] ixgbe: do not update stats twice each receive Jeff Kirsher
2008-08-26 11:27 ` [NET-NEXT PATCH 05/13] ixgbe: Cleanup references to Tx and Rx rings to becommon across the driver Jeff Kirsher
2008-08-26 11:27 ` [NET-NEXT PATCH 06/13] ixgbe: disable flow control by default Jeff Kirsher
2008-08-26 11:27 ` [NET-NEXT PATCH 07/13] ixgbe: Implement Tx Head Writeback Jeff Kirsher
2008-08-26 11:27 ` [NET-NEXT PATCH 08/13] ixgbe: Lock RSS seed, move rx_buf_len to the rx_ring Jeff Kirsher
2008-08-26 11:27 ` [NET-NEXT PATCH 09/13] ixgbe: should not use HW_CSUM, should use IP* flags Jeff Kirsher
2008-08-26 11:27 ` [NET-NEXT PATCH 10/13] ixgbe: update dca to new interface, fix CONFIG_DCA_MODULE Jeff Kirsher
2008-08-26 11:27 ` [NET-NEXT PATCH 11/13] ixgbe: fix bug where lro settings are per ring Jeff Kirsher
2008-08-26 11:27 ` [NET-NEXT PATCH 12/13] ixgbe: fix dca hints going to wrong processor Jeff Kirsher
2008-08-26 11:27 ` [NET-NEXT PATCH 13/13] ixgbe: use different context for tso and offload Jeff Kirsher
2008-09-03 14:03 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48BE9947.4060703@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.