From: Jeff Garzik <jeff@garzik.org>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: Adrian Bunk <bunk@kernel.org>, Jeff Garzik <jgarzik@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [2.6 patch] wan/hdlc_x25.c: fix a NULL dereference
Date: Wed, 03 Sep 2008 10:12:34 -0400 [thread overview]
Message-ID: <48BE9B52.8050003@garzik.org> (raw)
In-Reply-To: <m3bpz9glik.fsf@maximus.localdomain>
Krzysztof Halasa wrote:
> Adrian Bunk <bunk@kernel.org> writes:
>
>> --- a/drivers/net/wan/hdlc_x25.c
>> +++ b/drivers/net/wan/hdlc_x25.c
>> @@ -163,10 +163,8 @@ static void x25_close(struct net_device *dev)
>>
>> static int x25_rx(struct sk_buff *skb)
>> {
>> - if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL) {
>> - skb->dev->stats.rx_dropped++;
>> + if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL)
>> return NET_RX_DROP;
>> - }
>>
>
> Right, thanks... though I will update the stats anyway.
In terms of patches... what does this mean? Does this mean you are
taking Adrian's patch, and updating it? Sending a follow-up patch?
Ack'ing Adrian's patch?
I don't want to hold this back due to lack of stat update...
next prev parent reply other threads:[~2008-09-03 14:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-27 22:05 [2.6 patch] wan/hdlc_x25.c: fix a NULL dereference Adrian Bunk
2008-08-29 7:08 ` Herbert Xu
2008-08-31 17:08 ` Krzysztof Halasa
2008-09-03 14:12 ` Jeff Garzik [this message]
2008-09-03 16:14 ` Krzysztof Halasa
2008-09-03 16:21 ` Krzysztof Halasa
2008-09-13 19:56 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48BE9B52.8050003@garzik.org \
--to=jeff@garzik.org \
--cc=bunk@kernel.org \
--cc=jgarzik@redhat.com \
--cc=khc@pm.waw.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.