Re: [PATCH v3 1/2] powerpc: Board support for GE Fanuc SBC610

[Jerry Van Baren <gvb.linuxppc.dev@gmail.com>]

Martyn Welch wrote:
> On Fri, 29 Aug 2008 07:04:18 -0500
> Kumar Gala <galak@kernel.crashing.org> wrote:
> 
>> On Aug 26, 2008, at 8:13 AM, Martyn Welch wrote:
>>
>>> +
>>> +		PowerPC,8641@0 {
>>> +			device_type = "cpu";
>>> +			reg = <0x00000000>;
>>> +			d-cache-line-size = <32>;	// 32 bytes
>>> +			i-cache-line-size = <32>;	// 32 bytes
>>> +			d-cache-size = <32768>;		// L1, 32K
>>> +			i-cache-size = <32768>;		// L1, 32K
>>> +			timebase-frequency = <0>;	// From uboot
>>> +			bus-frequency = <0>;		// From uboot
>>> +			clock-frequency = <0>;		// From uboot
>> you can remove these since u-boot will set them.
>>
> 
> Ok.

Only if you update your u-boot version.

>>> +		};
>>> +		PowerPC,8641@1 {
>>> +			device_type = "cpu";
>>> +			reg = <0x00000001>;
>>> +			d-cache-line-size = <32>;	// 32 bytes
>>> +			i-cache-line-size = <32>;	// 32 bytes
>>> +			d-cache-size = <32768>;		// L1, 32K
>>> +			i-cache-size = <32768>;		// L1, 32K
>>> +			timebase-frequency = <0>;	// From uboot
>>> +			bus-frequency = <0>;		// From uboot
>>> +			clock-frequency = <0>;		// From uboot
>> you can remove these since u-boot will set them.

Ditto.

> Will do.
> 
>>> +		};
>>> +	};
>>> +
>>> +	memory {
>>> +		device_type = "memory";
>>> +		reg = <0x00000000 0x40000000>;	// set by u-boot
>> if the comment is zero just set it to <0 0>;
>>
> 
> So "reg = <0x0 0x40000000>;" ?
> 
>>> +	};
>>> +
>> what u-boot version are you using/shipping with these boards?
> 
> U-boot 1.2.0

1.2.0 predates the libfdt support.  You probably don't have any fdt 
support in your u-boot (if you do, it is old and crude and probably 
doesn't any of the fixups that Kumar refers to).

I would strongly recommend you upgrade to the tip o' the tree or at 
least the latest release (1.3.4).  FDT support will be *much* better - 
we now has generic utility routines that fix up lots of stuff for you 
rather than the crufty by-hand fixups (if any) from the 1.2.0 timeframe.

>> Wondering if other props (like cache info, is set by u-boot for you).

Probably none unless Martyn upgrades.

>> - k
> 
> Martyn

HTH,
gvb