All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Haley <brian.haley@hp.com>
To: Julius Volz <juliusv@google.com>
Cc: "Simon Horman" <horms@verge.net.au>,
	netdev@vger.kernel.org, lvs-devel@vger.kernel.org,
	"Malcolm Turnbull" <malcolm@loadbalancer.org>,
	"Siim Põder" <siim@p6drad-teel.net>,
	"Vince Busam" <vbusam@google.com>
Subject: Re: [PATCH 2/2] ipvs: load balance ipv6 connections from a local process
Date: Fri, 05 Sep 2008 11:55:44 -0400	[thread overview]
Message-ID: <48C15680.7010004@hp.com> (raw)
In-Reply-To: <f4845fc0809050440g24f304d9xec7982e984830c6e@mail.gmail.com>

Julius Volz wrote:
>> -out:
>> -       __ip_vs_conn_put(cp);
>> -
>> -       return verdict;
>> +       snet.in6 = iph->saddr;
> 
> I've always been told to use ipv6_addr_copy() for this. I'm not sure
> what the problem with the direct struct assignment is though... would
> be nice if someone could explain.

Because an in6_addr is a union of 4 u32's, which won't all be copied in 
a struct assignment.  That's the way I've always understood it.

-Brian

  reply	other threads:[~2008-09-05 15:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-05  1:36 [PATCH 1/2] ipvs: load balance IPv4 connections from a local process Simon Horman
2008-09-05  1:37 ` [PATCH 2/2] ipvs: load balance ipv6 " Simon Horman
2008-09-05 11:40   ` Julius Volz
2008-09-05 15:55     ` Brian Haley [this message]
2008-09-05 16:37       ` Julius Volz
2008-09-06  4:14     ` Simon Horman
2008-09-06  9:26       ` Julius Volz
2008-09-08  0:30         ` Simon Horman
2008-09-08  1:48         ` Simon Horman
2008-09-08  9:30           ` Julius Volz
2008-09-08  9:50             ` Simon Horman
2008-09-05  5:12 ` [PATCH 1/2] ipvs: load balance IPv4 " Julian Anastasov
2008-09-05  5:49   ` Siim Põder
2008-09-05  5:49     ` Siim Põder
2008-09-06  7:43     ` Simon Horman
2008-09-05 11:02 ` Julius Volz
2008-09-06  3:56   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48C15680.7010004@hp.com \
    --to=brian.haley@hp.com \
    --cc=horms@verge.net.au \
    --cc=juliusv@google.com \
    --cc=lvs-devel@vger.kernel.org \
    --cc=malcolm@loadbalancer.org \
    --cc=netdev@vger.kernel.org \
    --cc=siim@p6drad-teel.net \
    --cc=vbusam@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.