From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH 11/11][v3]: Enable multiple instances of devpts Date: Sat, 06 Sep 2008 07:05:49 -0700 Message-ID: <48C28E3D.6060404@zytor.com> References: <48BF8283.7040601@zytor.com> <20080904155431.GA11174@us.ibm.com> <48C00698.8050803@zytor.com> <20080904172542.3ad7bb85@lxorguk.ukuu.org.uk> <48C01163.1050704@zytor.com> <20080904171828.GC11174@us.ibm.com> <48C01B58.2040006@zytor.com> <20080905020131.GA17535@us.ibm.com> <20080905132710.50018aef@lxorguk.ukuu.org.uk> <48C16B42.7030103@zytor.com> <20080905194450.GA18119@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080905194450.GA18119-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org Cc: kyle-hoO6YkzgTuCM0SS3m2neIg@public.gmane.org, sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, bastian-yyjItF7Rl6lg9hUCZPvPmw@public.gmane.org, containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org, xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, Alan Cox , ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org List-Id: containers.vger.kernel.org sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org wrote: > Agree in general. Not sure if you are implying remount is necessary just > to change permissions of pts/ptmx. Why not "chmod 0666 /dev/pts/ptmx" ? > The remount changes the 'ptmxmode' setting, but since the node exists, > the 'ptmxmode' setting is never used again and we need to chmod. A chmod requires bigger changes to existing scripts than an option which can be set in /etc/fstab. > ptmx node in multi-instance mounts continue to get PTMX_DEFAULT_MODE > permissions (not 000) right ? (unless -o ptmxmode is specified) It's probably easier to always default it to zero and expect that the mode is set explicitly. -hpa