From: Larry Finger <Larry.Finger@lwfinger.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: bcm43xx-dev@lists.berlios.de,
John W Linville <linville@tuxdriver.com>,
Tim Gardner <tim.gardner@canonical.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] b43legacy: Fix failure in rate-adjustment mechanism
Date: Sat, 06 Sep 2008 13:52:53 -0500 [thread overview]
Message-ID: <48C2D185.4000003@lwfinger.net> (raw)
In-Reply-To: <200809062041.06035.mb@bu3sch.de>
Michael Buesch wrote:
> On Saturday 06 September 2008 20:34:02 Larry Finger wrote:
>> A coding error present since b43legacy was incorporated into the
>> kernel has prevented the driver from using the rate-setting mechanism
>> of mac80211. The driver has been forced to remain at a 1 Mb/s rate.
>
> Does version3 firmware have a different bitlayout for the status?
It seems so. I found this because I was not getting any acks back to
net/mac80211/rc80211_pid_algo.c. I then reviewed the V3 specs, found
that bit 0, not bit 1, contained the ack. Test prints confirmed that
result. With this patch, both my BCM4306/2 and BCM4303 reach the
maximum rate. With the current code, 54 Mb/s is not as fast as 36
Mb/s, but at least the algorithm is working.
Larry
next prev parent reply other threads:[~2008-09-06 18:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-06 18:34 [PATCH] b43legacy: Fix failure in rate-adjustment mechanism Larry Finger
2008-09-06 18:41 ` Michael Buesch
2008-09-06 18:44 ` John W. Linville
2008-09-06 18:52 ` Larry Finger [this message]
2008-09-06 18:55 ` Michael Buesch
2008-09-06 18:57 ` Johannes Berg
2008-09-06 19:04 ` Michael Buesch
2008-09-06 19:36 ` Larry Finger
2008-09-06 19:41 ` Johannes Berg
2008-09-06 19:59 ` Larry Finger
2008-09-06 20:02 ` Johannes Berg
2008-09-06 20:07 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C2D185.4000003@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=tim.gardner@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.