From: Avi Kivity <avi@qumranet.com>
To: Jes Sorensen <jes@sgi.com>
Cc: kvm@vger.kernel.org
Subject: Re: [patch] fix prototypes in qemu posix code
Date: Sun, 07 Sep 2008 09:31:50 +0300 [thread overview]
Message-ID: <48C37556.2070401@qumranet.com> (raw)
In-Reply-To: <48C138D8.9030207@sgi.com>
Jes Sorensen wrote:
> Hi,
>
> Small patch to eliminate some compiler warnings.
>
> Cheers,
> Jes
> #include "exec-all.h"
> #else
> #define kvm_enabled() 0
> -#define qemu_kvm_aio_start() ((void)0)
> -#define qemu_kvm_aio_end() ((void)0)
> -#define qemu_kvm_aio_wait() ((void)0)
> -#define qemu_kvm_aio_poll() ((void)0)
> +#define qemu_kvm_aio_wait() do{}while(0)
> +#define qemu_kvm_aio_poll() do{}while(0)
> +void qemu_kvm_aio_wait_start(void);
> +void qemu_kvm_aio_wait_end(void);
Better to have this as an inline function; that's the best way to avoid
misuse.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2008-09-07 6:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-05 13:49 [patch] fix prototypes in qemu posix code Jes Sorensen
2008-09-07 6:31 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C37556.2070401@qumranet.com \
--to=avi@qumranet.com \
--cc=jes@sgi.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.