From: Avi Kivity <avi@qumranet.com>
To: "Yang, Sheng" <sheng.yang@intel.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH][REPOST] KVM: VMX: Always return 0 for clear_flush_young() when using EPT
Date: Sun, 07 Sep 2008 16:31:54 +0300 [thread overview]
Message-ID: <48C3D7CA.4030506@qumranet.com> (raw)
In-Reply-To: <200809040929.02012.sheng.yang@intel.com>
Yang, Sheng wrote:
> Hi Avi
>
> It seems something wrong with my git-send-email, and I can't got my post from
> kvm@vger.kernel.org, so resend it. Sorry for inconvenient.
>
- _young = _spte & PT_ACCESSED_MASK;
- if (_young) {
- young = 1;
- clear_bit(PT_ACCESSED_SHIFT, (unsigned long *)spte);
+
+ /* always return old for EPT */
+ if (!shadow_accessed_mask)
+ _young = 0;
+ else {
+ _young = _spte & PT_ACCESSED_MASK;
+ if (_young) {
+ young = 1;
+ clear_bit(PT_ACCESSED_SHIFT,
+ (unsigned long *)spte);
+ }
Why not to a
if (!shadow_access_mask)
return 0;
in the beginning?
I guess returning 'old' is safer than returning 'young'.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-09-07 13:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-04 1:29 [PATCH][REPOST] KVM: VMX: Always return 0 for clear_flush_young() when using EPT Yang, Sheng
2008-09-07 13:31 ` Avi Kivity [this message]
2008-09-08 7:22 ` Yang, Sheng
2008-09-11 8:48 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C3D7CA.4030506@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm@vger.kernel.org \
--cc=sheng.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.