From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KcMf9-0002Ta-Go for mharc-grub-devel@gnu.org; Sun, 07 Sep 2008 11:58:55 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KcMf8-0002TK-Co for grub-devel@gnu.org; Sun, 07 Sep 2008 11:58:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KcMf6-0002Sk-Vm for grub-devel@gnu.org; Sun, 07 Sep 2008 11:58:54 -0400 Received: from [199.232.76.173] (port=45212 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KcMf6-0002Sd-Ik for grub-devel@gnu.org; Sun, 07 Sep 2008 11:58:52 -0400 Received: from mta-out.inet.fi ([195.156.147.13]:40343 helo=jenni2.inet.fi) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KcMf6-00069a-8r for grub-devel@gnu.org; Sun, 07 Sep 2008 11:58:52 -0400 Received: from [127.0.0.1] (88.193.32.97) by jenni2.inet.fi (8.5.014) id 489066C501CB873E for grub-devel@gnu.org; Sun, 7 Sep 2008 18:58:51 +0300 Message-ID: <48C3FA47.7070807@nic.fi> Date: Sun, 07 Sep 2008 18:59:03 +0300 From: =?ISO-8859-1?Q?Vesa_J=E4=E4skel=E4inen?= User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: The development of GRUB 2 References: <20080830235655.56f41dc5@gamma.lan> In-Reply-To: <20080830235655.56f41dc5@gamma.lan> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: Quoted-Printable X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] GSoC #06 VBE optimization for BGR/BGRA color modes X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Sep 2008 15:58:54 -0000 Colin D Bennett wrote: > This patch adds optimized routines for video modes using BGR/BGRA color > format. Most PC video cards use BGR (24-bit) or BGRA (32-bit) color > modes, so this is an extremely important change and provides a massive > performance benefit. >=20 > I also renamed the R8G8B8A8 and R8B8B8 modes to RGBA8888 and RGB888, > etc., since it began to be highly unreadable when B8G8R8A8 was added > into the mix. It seems that having the color components (letters) > grouped together in the name makes it much easier for me to determine > the mode name at a glance. Thanks for the patch. I have committed similar version to SVN. I made some changes there so apologies if it broke something in between. I was only able to test it on qemu and it was ok there, but that is far =66rom complete test. So please test it on real hardware with different cards and if problems are found report them back. Thanks, Vesa J=E4=E4skel=E4inen