From: "H. Peter Anvin" <hpa@zytor.com>
To: Alain Knaff <alain@knaff.lu>
Cc: Steven Noonan <steven.noonan@uplinklabs.net>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] init: bzip2 or lzma -compressed kernels and initrds
Date: Sun, 07 Sep 2008 09:30:09 -0700 [thread overview]
Message-ID: <48C40191.8070208@zytor.com> (raw)
In-Reply-To: <48C38571.7060808@knaff.lu>
Alain Knaff wrote:
>
> Could you elaborate please?
>
At a brief glance, there is an awful lot of #ifdefs in that code, a lot
of which look unnecessary. #ifdefs make the code hard to read, and
usually signify that additional abstractions are called for.
-hpa
next prev parent reply other threads:[~2008-09-07 16:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-06 21:19 [PATCH] init: bzip2 or lzma -compressed kernels and initrds Alain Knaff
2008-09-06 22:29 ` Leon Woestenberg
2008-09-06 22:59 ` Alain Knaff
2008-09-07 6:17 ` Rob Landley
2008-09-08 8:35 ` H. Peter Anvin
2008-09-08 13:14 ` Jörn Engel
2008-09-07 3:18 ` H. Peter Anvin
2008-09-07 4:35 ` Steven Noonan
2008-09-07 4:46 ` H. Peter Anvin
2008-09-07 7:40 ` Alain Knaff
2008-09-07 16:30 ` H. Peter Anvin [this message]
2008-09-07 7:39 ` Alain Knaff
2008-09-07 8:03 ` Yinghai Lu
2008-09-07 9:17 ` Alain Knaff
2008-09-07 5:48 ` Willy Tarreau
2008-09-07 8:59 ` Alain Knaff
2008-09-15 1:37 ` Rob Landley
2008-09-15 12:46 ` Frans Meulenbroeks
2008-09-15 17:13 ` Bill Davidsen
2008-09-15 17:28 ` Steven Noonan
2008-09-26 18:53 ` Leon Woestenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C40191.8070208@zytor.com \
--to=hpa@zytor.com \
--cc=alain@knaff.lu \
--cc=linux-kernel@vger.kernel.org \
--cc=steven.noonan@uplinklabs.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.