From: Akio Takebe <takebe_akio@jp.fujitsu.com>
To: John Levon <levon@movementarian.org>
Cc: xen-devel@lists.xensource.com
Subject: Re: xm dump-core options are useless
Date: Mon, 08 Sep 2008 10:40:32 +0900 [thread overview]
Message-ID: <48C48290.40506@jp.fujitsu.com> (raw)
In-Reply-To: <20080905132333.GB22002@totally.trollied.org.uk>
John Levon wrote:
> On Fri, Sep 05, 2008 at 11:09:39AM +0900, Akio Takebe wrote:
>
>>> xm dump-core [-L|--live][-C| --crash] <domID> [output path]
>>>
>>> Didn't actually implement anything. Worse, it looks like we don't even
>>> pause the domain, so it's always live (not good). What's going on?
>>>
>> What do you mean? Why do you think "it looks like we don't even
>> pause the domain"? The following code of the patch looks like
>> we do pause domain by server.xend.domain.pause(dom).
>
> You are doing this stuff in xm which I missed due to the pointless
> passing in of 'live' and 'crash' in the xend API.
>
> This should be happening in the server not in the client if you're going
> to pass the options in. In particular libvirt, but anything else that
> isn't 'xm', is forced to do live dumps - not good.
>
> I'll send a patch out shortly that implements them in the proper place.
>
Yes, I agree with you. I also think it is not good.
We implemented it before for improving xend downtime at dump-core.
http://lists.xensource.com/archives/html/xen-devel/2007-09/msg00576.html
Best Regards,
Akio Takebe
next prev parent reply other threads:[~2008-09-08 1:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-04 23:49 xm dump-core options are useless John Levon
2008-09-05 2:09 ` Akio Takebe
2008-09-05 13:23 ` John Levon
2008-09-07 23:47 ` Masaki Kanno
2008-09-08 1:40 ` Akio Takebe [this message]
2008-09-05 7:36 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C48290.40506@jp.fujitsu.com \
--to=takebe_akio@jp.fujitsu.com \
--cc=levon@movementarian.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.