From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kca5U-0007tN-AV
	for qemu-devel@nongnu.org; Mon, 08 Sep 2008 02:19:00 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kca5T-0007pK-5F
	for qemu-devel@nongnu.org; Mon, 08 Sep 2008 02:18:59 -0400
Received: from [199.232.76.173] (port=53161 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kca5S-0007oH-5a
	for qemu-devel@nongnu.org; Mon, 08 Sep 2008 02:18:58 -0400
Received: from fmmailgate02.web.de ([217.72.192.227]:55675)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jan.kiszka@web.de>) id 1Kca5Q-00044l-Gy
	for qemu-devel@nongnu.org; Mon, 08 Sep 2008 02:18:57 -0400
Message-ID: <48C4C3C8.5040005@web.de>
Date: Mon, 08 Sep 2008 08:18:48 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] pcnet: add loopback mode emulation
References: <48BD26AF.7050404@siemens.com> <48C46FD4.7020905@codemonkey.ws>
In-Reply-To: <48C46FD4.7020905@codemonkey.ws>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig1CEA8418E7C76F0B2DD6E509"
Sender: jan.kiszka@web.de
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig1CEA8418E7C76F0B2DD6E509
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Anthony Liguori wrote:
> Jan Kiszka wrote:
>> This patch enhances the pcnet NIC emulation with better loopback mode
>> support, including CRC generation for looped-back packets in "raw" mod=
e.
>> The patch has practically no impact on the normal RX and TX path.
>>
>> Successfully tested against an ancient proprietary pcnet driver that
>> does a lot of hardware checks on boot-up and now works fine over qemu =
as
>> well.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>  hw/pcnet.c |   89
>> ++++++++++++++++++++++++++++++++++++++++---------------------
>>  1 file changed, 59 insertions(+), 30 deletions(-)
>>
>> Index: b/hw/pcnet.c
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> --- a/hw/pcnet.c
>> +++ b/hw/pcnet.c
>> @@ -35,6 +35,8 @@
>>   *
>> http://www.ibiblio.org/pub/historic-linux/early-ports/Sparc/NCR/NCR92C=
990.txt
>>
>>   */
>> =20
>> +#include <netinet/in.h>
>>
>>  =20
>=20
> That'll break the windows build.  It's not immediately clear to me why
> you're including netinet/in.h.  Is it for htonl?  I think arpa/inet.h i=
s
> where htonl is defined...
>=20
> At any rate, qemu_socket.h is probably what you want, but I'd like to
> know why you're adding it in the first place.

htonl, and it was fixed in SVN just as you suggested.

Jan


--------------enig1CEA8418E7C76F0B2DD6E509
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkjEw8oACgkQniDOoMHTA+n1vACfYxJUMC1GiVoN57uWICAtHaa5
V5gAn3x5WKIYDCh1ZhMegd9gEbmQkQho
=Wovb
-----END PGP SIGNATURE-----

--------------enig1CEA8418E7C76F0B2DD6E509--