Re: [usb-storage] USB storage devices and SAT

[Boaz Harrosh <bharrosh@panasas.com>]

matthieu castet wrote:
> Hi,
> 
> Boaz Harrosh wrote:
>> There was a correct and simple patch proposed that fixes this problem
>> the right way:
>> http://marc.info/?l=linux-usb&m=121762869915609&w=2
>>
>> Doug could you please test this patch to see if it fixes your device?
>>
>> scsi-core already gives drivers complete control on what sense_size to
>> fetch. It is a parameter to the scsi_eh_prep_cmnd() call. So no need
>> for slave_configure(), default value, and all that loop.
>>
>> Matthieu castet <castet.matthieu@free.fr> wrote ...
>>> we have got report from 2 users that scsi sat (to do ata passthrough)  was not fully \
>>> working with some usb bridge (maxtor and western digital). Everything works except \
>>> the sense result was incomplete [1].
>>>
>>>
>>> After some investigation, they need a sense size different of 18 (at least 22). [2]
>>>
>>> Because some devices can crash if the sense size is different of 18, in order to not \
>>> break these devices a flag that is set either by unusual entries, either for spc3 or \
>>> latter devices is used.
>>>
>>>
>>> Signed-off-by: Matthieu CASTET <castet.matthieu@free.fr>
>> Reviewed-by: Boaz Harrosh <bharrosh@panasas.com>
>>
> What the status of that.
> 
> Should I try to resubmit that patch on linux-usb ?
> 

I see the To: is me. But I'm not a USB guy at all.

Like you said, I too think the best is to freshen up the 
patch for latest USB tree and send it to the USB mailing
list.

Cheers
Boaz