From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KccKJ-0008OU-PD for qemu-devel@nongnu.org; Mon, 08 Sep 2008 04:42:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KccKH-0008Jf-7Z for qemu-devel@nongnu.org; Mon, 08 Sep 2008 04:42:26 -0400 Received: from [199.232.76.173] (port=51107 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KccKH-0008JP-0R for qemu-devel@nongnu.org; Mon, 08 Sep 2008 04:42:25 -0400 Received: from gecko.sbs.de ([194.138.37.40]:24050) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KccKF-0007oz-N7 for qemu-devel@nongnu.org; Mon, 08 Sep 2008 04:42:24 -0400 Message-ID: <48C4E568.6010502@siemens.com> Date: Mon, 08 Sep 2008 10:42:16 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <486CF559.5090805@siemens.com> <48AC2E09.3030405@siemens.com> <48AC2EE9.8050803@siemens.com> <48C33916.6010608@codemonkey.ws> <20080907071547.GA30579@volta.aurel32.net> In-Reply-To: <20080907071547.GA30579@volta.aurel32.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [RESEND][PATCH 2/13] Refactor and enhance break/watchpoint API Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl , Paul Brook Aurelien Jarno wrote: > On Sat, Sep 06, 2008 at 09:14:46PM -0500, Anthony Liguori wrote: >> Does anyone have any objections to this series? It literally touches >> every architectures so I don't want to commit it without some Ack'ing >> for the appropriate architecture maintainers. >> >> I've heard a lot of reports recently that gdb support in QEMU for x86 is >> pretty broken so I think the refactoring is needed. >> > > After a quick look, it is ok from my side. Note however that the patch > changes code that has been changed recently on the SH4 target and > probably on the Alpha and PPC ones (TCG conversion). It should not be > really difficult to merge the patch by hand though. Will send out a rebased version later (maybe I already have it 'cause I rebased end of last week - I just need to sort out the new compiler warnings I get with today's SVN head). Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux