From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KciUY-0005ws-CT for mharc-grub-devel@gnu.org; Mon, 08 Sep 2008 11:17:26 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KciUV-0005tT-Bf for grub-devel@gnu.org; Mon, 08 Sep 2008 11:17:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KciUT-0005rT-EY for grub-devel@gnu.org; Mon, 08 Sep 2008 11:17:22 -0400 Received: from [199.232.76.173] (port=43009 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KciUT-0005rK-9f for grub-devel@gnu.org; Mon, 08 Sep 2008 11:17:21 -0400 Received: from mta-out.inet.fi ([195.156.147.13]:56495 helo=kirsi2.inet.fi) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KciUS-0005gn-RO for grub-devel@gnu.org; Mon, 08 Sep 2008 11:17:21 -0400 Received: from [127.0.0.1] (88.193.32.97) by kirsi2.inet.fi (8.5.014) id 488DC54E01EEDB84 for grub-devel@gnu.org; Mon, 8 Sep 2008 18:17:20 +0300 Message-ID: <48C5420E.8030805@nic.fi> Date: Mon, 08 Sep 2008 18:17:34 +0300 From: =?ISO-8859-1?Q?Vesa_J=E4=E4skel=E4inen?= User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: The development of GRUB 2 References: <20080908134723.GA22051@thorin> <20080908104902.o5gbh1bm2o8cssgs-cebfxv@webmail.spamcop.net> <20080908150920.GA24943@thorin> In-Reply-To: <20080908150920.GA24943@thorin> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] Move normal, serial & pci to i386.rmk X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Sep 2008 15:17:24 -0000 Robert Millan wrote: > On Mon, Sep 08, 2008 at 10:49:02AM -0400, Pavel Roskin wrote: >> Quoting Robert Millan : >> >>> This patch moves normal, serial and pci to conf/i386.rmk. >> Why i386? That code is not i386 specific. > > It is. Notice it's being moved from conf/i386-*.rmk, not common.rmk. > > normal: Includes normal/i386/setjmp.S Should we move this out of normal.mod ?