From: Stefan Raspl <raspl@linux.vnet.ibm.com>
To: device-mapper development <dm-devel@redhat.com>, agk@redhat.com
Cc: akpm@linux-foundation.org, h.carstens@de.ibm.com,
martin.schwidefsky@de.ibm.com
Subject: [PATCH] Fix Null pointer Exception
Date: Mon, 08 Sep 2008 17:40:59 +0200 [thread overview]
Message-ID: <48C5478B.2040401@linux.vnet.ibm.com> (raw)
Here's a trivial patch for the kernel panics that we reported last week
when testing various ways to forcefully disconnect or temporarily disable
DASD disks from an IBM System z machine. We ran into NULL pointer exceptions
at the respective places.
Signed-off-by: Stefan Raspl <raspl@linux.vnet.ibm.com>
---
drivers/md/dm-table.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -943,7 +943,8 @@ int dm_table_any_congested(struct dm_tab
list_for_each_entry(dd, devices, list) {
struct request_queue *q = bdev_get_queue(dd->bdev);
- r |= bdi_congested(&q->backing_dev_info, bdi_bits);
+ if (q)
+ r |= bdi_congested(&q->backing_dev_info, bdi_bits);
}
return r;
@@ -957,7 +958,8 @@ void dm_table_unplug_all(struct dm_table
list_for_each_entry(dd, devices, list) {
struct request_queue *q = bdev_get_queue(dd->bdev);
- blk_unplug(q);
+ if (q)
+ blk_unplug(q);
}
}
next reply other threads:[~2008-09-08 15:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 15:40 Stefan Raspl [this message]
2008-09-09 0:21 ` [PATCH] Fix Null pointer Exception Andrew Morton
2008-09-23 16:56 ` Alasdair G Kergon
2008-09-24 13:17 ` Stefan Raspl
2008-10-07 21:18 ` Alasdair G Kergon
2008-10-09 15:17 ` Alasdair G Kergon
2008-10-10 7:23 ` Stefan Raspl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C5478B.2040401@linux.vnet.ibm.com \
--to=raspl@linux.vnet.ibm.com \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dm-devel@redhat.com \
--cc=h.carstens@de.ibm.com \
--cc=martin.schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.