From: Eric Sandeen <sandeen@redhat.com>
To: ext4 development <linux-ext4@vger.kernel.org>
Subject: [PATCH] make all feature-related printks KERN_INFO and print barrier status as well
Date: Mon, 08 Sep 2008 12:08:30 -0500 [thread overview]
Message-ID: <48C55C0E.2050809@redhat.com> (raw)
A very trivial little tidy-up patch.
This slightly duplicates a little of patches/ext4_fix_printk_checkpatch_issues
but just in one hunk, easily fixed up.
Various feature printk's come out at different levels, so for example
at my default logging level I see mballoc & extents messages, but
not delalloc, even though they are all on.
Also, since default barrier behavior has changed, I thought perhaps always
printing the barrier state might be a good idea.
Seems ok?
Thanks,
-Eric
------------------------
Make extents, mballoc, and delalloc feature printks all at log level KERN_INFO.
Also print barrier status, whether on or off, since the defaults recently changed.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
Index: linux-2.6/fs/ext4/extents.c
===================================================================
--- linux-2.6.orig/fs/ext4/extents.c 2008-09-07 19:43:35.979702421 -0500
+++ linux-2.6/fs/ext4/extents.c 2008-09-08 12:02:58.580702852 -0500
@@ -2142,7 +2142,7 @@ void ext4_ext_init(struct super_block *s
*/
if (test_opt(sb, EXTENTS)) {
- printk("EXT4-fs: file extents enabled");
+ printk(KERN_INFO "EXT4-fs: file extents enabled");
#ifdef AGGRESSIVE_TEST
printk(", aggressive tests");
#endif
Index: linux-2.6/fs/ext4/mballoc.c
===================================================================
--- linux-2.6.orig/fs/ext4/mballoc.c 2008-09-07 19:43:36.813639634 -0500
+++ linux-2.6/fs/ext4/mballoc.c 2008-09-08 12:03:00.807640535 -0500
@@ -2560,7 +2560,7 @@ int ext4_mb_init(struct super_block *sb,
ext4_mb_init_per_dev_proc(sb);
ext4_mb_history_init(sb);
- printk("EXT4-fs: mballoc enabled\n");
+ printk(KERN_INFO "EXT4-fs: mballoc enabled\n");
return 0;
}
Index: linux-2.6/fs/ext4/super.c
===================================================================
--- linux-2.6.orig/fs/ext4/super.c 2008-09-07 19:43:36.603640074 -0500
+++ linux-2.6/fs/ext4/super.c 2008-09-08 12:03:00.266640232 -0500
@@ -2715,6 +2715,11 @@ static int ext4_load_journal(struct supe
return -EINVAL;
}
+ if (journal->j_flags & JBD2_BARRIER)
+ printk(KERN_INFO "EXT4-fs: barriers enabled\n");
+ else
+ printk(KERN_INFO "EXT4-fs: barriers disabled\n");
+
if (!really_read_only && test_opt(sb, UPDATE_JOURNAL)) {
err = jbd2_journal_update_format(journal);
if (err) {
next reply other threads:[~2008-09-08 17:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 17:08 Eric Sandeen [this message]
2008-09-08 21:10 ` [PATCH] make all feature-related printks KERN_INFO and print barrier status as well Theodore Tso
2008-09-08 21:20 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C55C0E.2050809@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.