From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1Kclaz-0004oC-CF
	for mharc-grub-devel@gnu.org; Mon, 08 Sep 2008 14:36:17 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kclax-0004nb-1l
	for grub-devel@gnu.org; Mon, 08 Sep 2008 14:36:15 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kclav-0004n2-LN
	for grub-devel@gnu.org; Mon, 08 Sep 2008 14:36:14 -0400
Received: from [199.232.76.173] (port=37517 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kclav-0004mt-Eu
	for grub-devel@gnu.org; Mon, 08 Sep 2008 14:36:13 -0400
Received: from mta-out.inet.fi ([195.156.147.13]:48100 helo=kirsi2.inet.fi)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <chaac@nic.fi>) id 1Kclau-0000ok-0r
	for grub-devel@gnu.org; Mon, 08 Sep 2008 14:36:13 -0400
Received: from [127.0.0.1] (88.193.32.97) by kirsi2.inet.fi (8.5.014)
	id 488DC54E01F12C6A for grub-devel@gnu.org;
	Mon, 8 Sep 2008 21:36:06 +0300
Message-ID: <48C57096.1020006@nic.fi>
Date: Mon, 08 Sep 2008 21:36:06 +0300
From: =?UTF-8?B?VmVzYSBKw6TDpHNrZWzDpGluZW4=?= <chaac@nic.fi>
User-Agent: Thunderbird 2.0.0.16 (Windows/20080708)
MIME-Version: 1.0
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <20080908134723.GA22051@thorin>	<20080908104902.o5gbh1bm2o8cssgs-cebfxv@webmail.spamcop.net>	<20080908150920.GA24943@thorin>
	<48C5420E.8030805@nic.fi> <20080908182409.GA31031@thorin>
In-Reply-To: <20080908182409.GA31031@thorin>
X-Enigmail-Version: 0.95.7
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: Quoted-Printable
X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3)
Subject: Re: [PATCH] Move normal, serial & pci to i386.rmk
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Sep 2008 18:36:15 -0000

Robert Millan wrote:
> On Mon, Sep 08, 2008 at 06:17:34PM +0300, Vesa J=C3=A4=C3=A4skel=C3=A4i=
nen wrote:
>> Robert Millan wrote:
>>> On Mon, Sep 08, 2008 at 10:49:02AM -0400, Pavel Roskin wrote:
>>>> Quoting Robert Millan <rmh@aybabtu.com>:
>>>>
>>>>> This patch moves normal, serial and pci to conf/i386.rmk.
>>>> Why i386?  That code is not i386 specific.
>>> It is.  Notice it's being moved from conf/i386-*.rmk, not common.rmk.
>>>
>>> normal:  Includes normal/i386/setjmp.S
>> Should we move this out of normal.mod ?
>=20
> You mean as a standalone module, or to kernel?  In a standalone module,=
 we'd
> still want to have that module in i386.rmk?  Then it's basicaly the sam=
e
> issue.  And in kernel there's the problem about size...
>=20

Or another option is to put all common stuff in common.rmk and then
concatenate platform features in platform specific .rmk.