All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <liml@rtr.ca>
To: Simon Farnsworth <simon.farnsworth@onelan.co.uk>
Cc: Frans Pop <elendil@planet.nl>, Saeed Bishara <saeed@marvell.com>,
	linux-ide@vger.kernel.org, linux-arm@vger.kernel.org,
	jeff@garzik.org, grundler@google.com, buytenh@marvell.com,
	nico@marvell.com, tbm@cyrius.com
Subject: Re: [PATCH] sata_mv: enable active LED blink mode for SoC
Date: Mon, 08 Sep 2008 14:44:57 -0400	[thread overview]
Message-ID: <48C572A9.2070009@rtr.ca> (raw)
In-Reply-To: <48C54238.9050106@onelan.co.uk>

Simon Farnsworth wrote:
>..
> Setting queue_depth to 1 is not disabling NCQ; it's NCQ enabled, no more
> than one command outstanding at a time. A queue depth of 0 disables NCQ
> completely.
..

Unfortunately, in the libata implementation, a queue depth of 1
actually *does* disable NCQ.  I wish it didn't (for easier testing
of features), but it does. 

Cheers

  parent reply	other threads:[~2008-09-08 18:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-07 11:19 [PATCH] sata_mv: enable active LED blink mode for SoC Saeed Bishara
2008-09-07 11:31 ` saeed bishara
2008-09-08  0:32 ` Frans Pop
2008-09-08 13:40   ` Mark Lord
2008-09-08 14:16     ` Frans Pop
2008-09-08 14:25       ` Frans Pop
2008-09-08 15:18         ` Simon Farnsworth
2008-09-08 15:37           ` Saeed Bishara
2008-09-08 18:44           ` Mark Lord [this message]
2008-09-08 18:47         ` Mark Lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48C572A9.2070009@rtr.ca \
    --to=liml@rtr.ca \
    --cc=buytenh@marvell.com \
    --cc=elendil@planet.nl \
    --cc=grundler@google.com \
    --cc=jeff@garzik.org \
    --cc=linux-arm@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=nico@marvell.com \
    --cc=saeed@marvell.com \
    --cc=simon.farnsworth@onelan.co.uk \
    --cc=tbm@cyrius.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.