From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KcqmF-0001cV-2O for mharc-grub-devel@gnu.org; Mon, 08 Sep 2008 20:08:15 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KcqmC-0001Zd-Rz for grub-devel@gnu.org; Mon, 08 Sep 2008 20:08:12 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KcqmA-0001YR-MB for grub-devel@gnu.org; Mon, 08 Sep 2008 20:08:11 -0400 Received: from [199.232.76.173] (port=60281 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KcqmA-0001YF-F8 for grub-devel@gnu.org; Mon, 08 Sep 2008 20:08:10 -0400 Received: from fg-out-1718.google.com ([72.14.220.158]:58677) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kcqm9-000696-Rg for grub-devel@gnu.org; Mon, 08 Sep 2008 20:08:10 -0400 Received: by fg-out-1718.google.com with SMTP id l26so1592680fgb.30 for ; Mon, 08 Sep 2008 17:08:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=/2FBgswIIzgAVKoxnZr1Ut1UCoEViMYCXHekPMe60as=; b=Q2l/Nlxg/sQQ6EQCvbh0+myMdTWuF59aUpC/Y5KJOrn4DyXKCVH2HgsKmksctRH1YN AuaiT19eheK+c3GEs7pdPssUGRbAXfbjuuAP7X/B3jFdCsjpNqxZyj7Bu3GjMS9eWeCK 6dHun5ALpH1BUmMkf1UU7StYDlBNvX5Xso/sM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=PkOloYR9U+rSKRL/OBvFmrhi0DAtiNMoGTjgdDpW7P3ffFNsRxLtLTLNK6eoPny52p d2DGefOhLIH9iOx9wTA/jBUgno9lGx5GMwsDsId0614KAIJiRwquPW7Mqlm+oINS8dCx DFKjur5WCD4IDrWNld2oyFJpddV74FWlsUn+Q= Received: by 10.86.80.5 with SMTP id d5mr11809761fgb.26.1220918888887; Mon, 08 Sep 2008 17:08:08 -0700 (PDT) Received: from ?192.168.1.15? ( [83.77.136.137]) by mx.google.com with ESMTPS id d4sm5926572fga.5.2008.09.08.17.08.06 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 08 Sep 2008 17:08:07 -0700 (PDT) Message-ID: <48C5BE63.2010301@gmail.com> Date: Tue, 09 Sep 2008 02:08:03 +0200 From: phcoder User-Agent: Thunderbird 2.0.0.16 (X11/20080724) MIME-Version: 1.0 To: The development of GRUB 2 References: <48BED2B2.1060000@gmail.com> <20080904194015.GF9133@thorin> <48C05923.3060001@gmail.com> <20080908133815.GA21754@thorin> <48C56E79.9080502@gmail.com> <20080908183119.GC31031@thorin> In-Reply-To: <20080908183119.GC31031@thorin> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) Subject: Re: Multiple partition maps X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Sep 2008 00:08:13 -0000 Robert Millan wrote: > On Mon, Sep 08, 2008 at 08:27:05PM +0200, phcoder wrote: >> Robert Millan wrote: >>> On Thu, Sep 04, 2008 at 11:54:43PM +0200, phcoder wrote: >>>> BTW GPT module checks the protective MBR. In some cases when legay OS >>>> modified the MBR it's no longer "protective MBR". And in theese cases >>>> GRUB will refuse to boot. Isn't the magic number check enough? >>> If there's at least one protective GPT partition (0xee), I think this should >>> be considered enough to accept the partmap as GPT. >>> >> In GPT module if first partition is not of type 0xee then it's >> considered that no GPT is present. Is think that this check is >> error-prone (with e.g. bootcamp) and unnecessary > > Agreed. Can you fix this? > OK.