Re: [Patch] linux: avoid kmalloc while disabling interrupts

[Akio Takebe <takebe_akio@jp.fujitsu.com>]

Jan Beulich wrote:
>>>> Akio Takebe <takebe_akio@jp.fujitsu.com> 09.09.08 09:41 >>>
>> We should avoid using kmalloc while interrupts is disabled.
>> kmalloc may sleep.
>>
>> Signed-off-by: Akio Takebe <takebe_akio@jp.fujitsu.com>
> 
> I was under the impression that this is why the code uses GFP_ATOMIC.
> 
> Also, doesn't that patch introduce new problems, in dropping the lock
> intermediately and then adding entries to lists without checking for
> already existing entries again? I'd suppose if you want the allocations
> to be done outside of the lock, you should do them in advance
> (regardless of whether you'll actually need them) and free the memory
> after dropping the lock if the entries weren't really inserted anywhere.
> 
Sorry for my confusion.
As you said, it's my mistake.

Best Regards,

Akio Takebe