All of lore.kernel.org
 help / color / mirror / Atom feed
From: Naohiro Ooiwa <nooiwa@miraclelinux.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] sysrq: Add enable_mask in sysrq_moom_op
Date: Tue, 09 Sep 2008 20:33:45 +0900	[thread overview]
Message-ID: <48C65F19.1080105@miraclelinux.com> (raw)

Hi all

I found a little mistake.

It is written in the Documentation/sysrq.txt that oom-killer is enable
when we set "64" in /proc/sys/kernel/sysrq.
The following is it.

<Documentation/sysrq.txt>

    Here is the list of possible values in /proc/sys/kernel/sysrq:
         64 - enable signalling of processes (term, kill, oom-kill)
                                                          ^^^^^^^^

but enable_mask is not in sysrq_moom_op.
Could you please check the following patch ?



Signed-off-by: Naohiro Ooiwa <nooiwa@miraclelinux.com>
---
 drivers/char/sysrq.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/char/sysrq.c b/drivers/char/sysrq.c
index 8fdfe9c..2aa79ab 100644
--- a/drivers/char/sysrq.c
+++ b/drivers/char/sysrq.c
@@ -326,6 +326,7 @@ static struct sysrq_key_op sysrq_moom_op = {
 	.handler	= sysrq_handle_moom,
 	.help_msg	= "Full",
 	.action_msg	= "Manual OOM execution",
+	.enable_mask	= SYSRQ_ENABLE_SIGNAL,
 };

 static void sysrq_handle_kill(int key, struct tty_struct *tty)
-- 
1.5.4.1


                 reply	other threads:[~2008-09-09 11:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48C65F19.1080105@miraclelinux.com \
    --to=nooiwa@miraclelinux.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.