All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH 2/3] sysfs: sysfs_attr_get_value() writes to a buffer
Date: Wed, 10 Sep 2008 10:21:05 +0000	[thread overview]
Message-ID: <48C79F91.7010007@tuffmail.co.uk> (raw)
In-Reply-To: <48BFEEF4.8040000@tuffmail.co.uk>

Alan Jenkins wrote:
> This avoids lifetime issues with the returned string, for subsequent changes
> to caching in sysfs.  All callers are changed accordingly.  Many callers
> copied the result to a buffer already, so this actually simplifies some code.
>   

Sorry, my re-implementation of sysfs_attr_get_value() was defective.  It
didn't return cached values correctly.

I suggest you drop these two patches.  I'll fix the bug and update them
to apply on top of the recent libudev/logging changes.

Thanks
Alan

  reply	other threads:[~2008-09-10 10:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-04 14:21 [PATCH 2/3] sysfs: sysfs_attr_get_value() writes to a buffer instead Alan Jenkins
2008-09-10 10:21 ` Alan Jenkins [this message]
2008-09-10 11:09 ` [PATCH 2/3] sysfs: sysfs_attr_get_value() writes to a buffer Kay Sievers
2008-09-15 18:32 ` [PATCH 2/3] sysfs: sysfs_attr_get_value() writes to a buffer instead of returning a string Kay Sievers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48C79F91.7010007@tuffmail.co.uk \
    --to=alan-jenkins@tuffmail.co.uk \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.