From: Avi Kivity <avi@qumranet.com>
To: Laurent Vivier <Laurent.Vivier@bull.net>
Cc: KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: VMX: Leave atomic context while emulating real mode
Date: Wed, 10 Sep 2008 17:57:07 +0300 [thread overview]
Message-ID: <48C7E043.1010505@qumranet.com> (raw)
In-Reply-To: <1221055929.4232.11.camel@frecb07144>
Laurent Vivier wrote:
>> int err;
>>
>> + preempt_enable();
>> + local_irq_enable();
>> +
>> while (!guest_state_valid(vcpu)) {
>> err = emulate_instruction(vcpu, kvm_run, 0, 0, 0);
>>
>> @@ -2932,6 +2935,9 @@ static void handle_invalid_guest_state(struct kvm_vcpu *vcpu,
>> schedule();
>> }
>>
>> + local_irq_disable();
>> + preempt_enable();
>>
>
> should be a preempt_disable() ?
>
Yes.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2008-09-10 14:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080820140100.07333250A43@il.qumranet.com>
2008-09-10 14:12 ` [PATCH] KVM: VMX: Leave atomic context while emulating real mode Laurent Vivier
2008-09-10 14:57 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C7E043.1010505@qumranet.com \
--to=avi@qumranet.com \
--cc=Laurent.Vivier@bull.net \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.