All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcus Griep <marcus@griep.us>
To: Git Mailing List <git@vger.kernel.org>
Cc: Eric Wong <normalperson@yhbt.net>,
	Junio C Hamano <gitster@pobox.com>,
	"Tom G. Christensen" <tgc@statsbiblioteket.dk>
Subject: Re: [PATCH] git-svn: Fixes my() parameter list syntax error in pre-5.8 Perl
Date: Wed, 10 Sep 2008 11:11:15 -0400	[thread overview]
Message-ID: <48C7E393.2070006@griep.us> (raw)
In-Reply-To: <1221059386-3972-1-git-send-email-marcus@griep.us>

Sorry:

Signed-off-by: Marcus Griep <marcus@griep.us>

Marcus Griep wrote:
> ---
> 
>  Per Tom G. Christensen's commentary on a breaking test in git-svn.
> 
>  git-svn.perl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/git-svn.perl b/git-svn.perl
> index ecacf74..a97e1ca 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -4425,7 +4425,7 @@ sub config_pager {
>  
>  sub run_pager {
>  	return unless -t *STDOUT && defined $pager;
> -	pipe my $rfd, my $wfd or return;
> +	pipe my ($rfd, $wfd) or return;
>  	defined(my $pid = fork) or ::fatal "Can't fork: $!";
>  	if (!$pid) {
>  		open STDOUT, '>&', $wfd or

-- 
Marcus Griep
GPG Key ID: 0x5E968152
——
http://www.boohaunt.net
את.ψο´

  reply	other threads:[~2008-09-10 15:12 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-01  9:27 Git 1.6.0.1 breaks git-svn with perl 5.8.0 Tom G. Christensen
2008-09-01  9:46 ` Matthieu Moy
2008-09-01 10:04   ` [PATCH] Git.pm: Require File::Temp 0.14 for new() Abhijit Menon-Sen
2008-09-01 10:21     ` Tom G. Christensen
2008-09-01 10:42       ` [PATCH] Git.pm: Use File::Temp->tempfile instead of ->new Abhijit Menon-Sen
2008-09-01 11:03         ` Tom G. Christensen
2008-09-07  5:27           ` Junio C Hamano
2008-09-07  9:26             ` Abhijit Menon-Sen
2008-09-07 16:50               ` Marcus Griep
2008-09-08  8:05                 ` Abhijit Menon-Sen
2008-09-08 15:51                   ` Marcus Griep
2008-09-08 16:53                     ` [PATCH v2] " Marcus Griep
2008-09-09  1:53                       ` Eric Wong
2008-09-10  3:53                         ` Junio C Hamano
2008-09-10 10:09                           ` Eric Wong
2008-09-09  2:06                       ` Abhijit Menon-Sen
2008-09-09 17:35                         ` Marcus Griep
2008-09-09  7:41                       ` Tom G. Christensen
2008-09-09 17:55                         ` Marcus Griep
2008-09-10  7:16                           ` Tom G. Christensen
2008-09-10 15:09                             ` [PATCH] git-svn: Fixes my() parameter list syntax error in pre-5.8 Perl Marcus Griep
2008-09-10 15:11                               ` Marcus Griep [this message]
2008-09-01 10:13   ` Git 1.6.0.1 breaks git-svn with perl 5.8.0 Tom G. Christensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48C7E393.2070006@griep.us \
    --to=marcus@griep.us \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=normalperson@yhbt.net \
    --cc=tgc@statsbiblioteket.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.