From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gianluca Guida <gianluca.guida@eu.citrix.com>
Subject: Re: [PATCH] Fix arguments passed to SHADOW_PRINTK
Date: Thu, 11 Sep 2008 11:49:05 +0100
Message-ID: <48C8F7A1.7020309@eu.citrix.com>
References: <48C8F673.4070503@lab.ntt.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-2022-JP
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <48C8F673.4070503@lab.ntt.co.jp>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
Cc: Satoshi Moriai <moriai.satoshi@lab.ntt.co.jp>, xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Hi,


Yoshiaki Tamura wrote:
> Hi.
> 
> When I compiled xen-3.3-testing with DEBUG_TRACE_DUMP in xen/include/xen/lib.h
> turned on, I got some errors at SHADOW_PRINTK.
> The following patch will fix the arguments passed to SHADOW_PRINTK in
> xen/arch/x86/mm/shadow/common.c and xen/arch/x86/mm/shadow/multi.c.

My fault, the va argument was removed with recent changes in the OOS
code and it is unneeded now.

>      SHADOW_PRINTK("d=%d, v=%d, gmfn=%05lx, va=%lx\n",
> -                  v->domain->domain_id, v->vcpu_id, mfn_x(gmfn), va);
> +                  v->domain->domain_id, v->vcpu_id, mfn_x(gmfn),
> +                  sh_map_domain_page(gmfn));
> 
>      /* Need to pull write access so the page *stays* in sync. */
>      if ( oos_remove_write_access(v, gmfn, fixup) )
> @@ -953,7 +954,8 @@ int sh_unsync(struct vcpu *v, mfn_t gmfn
>      ASSERT(shadow_locked_by_me(v->domain));
> 
>      SHADOW_PRINTK("d=%d, v=%d, gmfn=%05lx va %lx\n",
> -                  v->domain->domain_id, v->vcpu_id, mfn_x(gmfn), va);
> +                  v->domain->domain_id, v->vcpu_id, mfn_x(gmfn),
> +                  sh_map_domain_page(gmfn));

These will likely break Xen in 32 bit, since you should unmap the gmfn
in those architecture. As I said, the va argument is unneeded now, so
you should remove it.

Thanks,
Gianluca