From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yoshiaki Tamura Subject: Re: [PATCH] Fix arguments passed to SHADOW_PRINTK Date: Thu, 11 Sep 2008 20:24:42 +0900 Message-ID: <48C8FFFA.30706@lab.ntt.co.jp> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel List-Id: xen-devel@lists.xenproject.org Keir and Gianluca, Keir Fraser wrote: > On 11/9/08 11:44, "Yoshiaki Tamura" wrote: > >> When I compiled xen-3.3-testing with DEBUG_TRACE_DUMP in xen/include/xen/lib.h >> turned on, I got some errors at SHADOW_PRINTK. >> The following patch will fix the arguments passed to SHADOW_PRINTK in >> xen/arch/x86/mm/shadow/common.c and xen/arch/x86/mm/shadow/multi.c. >> >> Although I haven't tested, it is the same for xen-unstable.hg > > First chunks of patch: If there is no longer a va to print, then don't > manufacture one to print; just remove it entirely from the printk. Apart > from anything else, using sh_map_domain_page() without > sh_unmap_domain_page() will leak mappings. And the va printed will not be > useful anyway. Sorry, that was my mistake. > Final chunk of patch: print regs->eip? That should work on both x86_64 and > i386. When I compiled xen-3.3-testing with DEBUG_TRACE_DUMP turned on, I got the following errors. Would you please tell me how to work around? multi.c: In function 'sh_page_fault__guest_2': multi.c:3045: error: 'struct cpu_user_regs' has no member named 'rip' multi.c: In function 'sh_page_fault__guest_3': multi.c:3045: error: 'struct cpu_user_regs' has no member named 'rip' make[6]: *** [guest_3.o] Error 1 make[6]: *** Waiting for unfinished jobs.... make[6]: *** [guest_2.o] Error 1 make[5]: *** [shadow/built_in.o] Error 2 make[4]: *** [mm/built_in.o] Error 2 make[3]: *** [/home/tamura/Developer/kemari-v1-devel.hg/xen/arch/x86/built_in.o] Error 2 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [/home/tamura/Developer/kemari-v1-devel.hg/xen/xen] Error 2 make[1]: *** [install] Error 2 make: *** [install-xen] Error 2 > > Please fix and re-send. > > Thanks, > Keir > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > > > -- TAMURA, Yoshiaki NTT Cyber Space Labs OSS Computing Project Kernel Group E-mail: tamura.yoshiaki@lab.ntt.co.jp TEL: +81-46-859-2771 FAX: +81-46-855-1152 Address: 1-1 Hikarinooka, Yokosuka Kanagawa 239-0847 JAPAN