From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KdmtX-0004Cz-Bl for qemu-devel@nongnu.org; Thu, 11 Sep 2008 10:11:39 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KdmtV-0004AS-Qu for qemu-devel@nongnu.org; Thu, 11 Sep 2008 10:11:38 -0400 Received: from [199.232.76.173] (port=53758 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KdmtV-0004AN-IA for qemu-devel@nongnu.org; Thu, 11 Sep 2008 10:11:37 -0400 Received: from il.qumranet.com ([212.179.150.194]:58010) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KdmtU-0000Pw-RC for qemu-devel@nongnu.org; Thu, 11 Sep 2008 10:11:37 -0400 Message-ID: <48C92717.3070201@qumranet.com> Date: Thu, 11 Sep 2008 17:11:35 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Don't use QEMU_VERSION in ATA/ATAPI replies to IDENTIFY cmds References: <5d6222a80809110444t75ec91fau15d8aaaaa7ea4173@mail.gmail.com> <20080911115629.GA16427@shareable.org> <200809111458.57906.paul@codesourcery.com> In-Reply-To: <200809111458.57906.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Paul Brook wrote: > The whole point of the drive firmware version is that it's supposed to change > every time bug fixes and performance improvements are made. I'm pretty sure > it'll also change when you upgrade the firmware on a real drive. > > As far as I'm concerned anything that relies on this value being constant over > qemu is just plain broken. > Your users must love you. -- error compiling committee.c: too many arguments to function