From: "H. Peter Anvin" <hpa@zytor.com>
To: Alain Knaff <alain@knaff.lu>
Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, w@1wt.eu
Subject: Re: [update3] [PATCH] init: bzip2 or lzma -compressed kernels and initrds
Date: Thu, 11 Sep 2008 16:21:49 -0700 [thread overview]
Message-ID: <48C9A80D.1010703@zytor.com> (raw)
In-Reply-To: <48C9A6C0.4070802@knaff.lu>
Alain Knaff wrote:
>> There is no reason to include header files conditionally.
>>
>> It might be worthwhile to create a proper subdirectory rather than using
>> an underscored namespace (also, in general, dashes are preferred in
>> filenames.)
>
> I hate to contradict you, but in that case, lots of other filenames
> would need fixing too:
Not arguing that. However, in this case I think the right thing is to
make a subdirectory.
>> Any reason to not just use <linux/compiler.h> here?
>
> As you may have understood, the decompressors themselves are samples
> and/or reference implementations downloaded from elsewhere, and thus
> might not be up to the coding standards of the rest of the kernel.
I'm familiar with that. However, I think in this case it is preferrable
to use the all-kernel facilities, since there is an obvious direct mapping.
-hpa
next prev parent reply other threads:[~2008-09-11 23:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-09 6:41 [update3] [PATCH] init: bzip2 or lzma -compressed kernels and initrds Alain Knaff
2008-09-11 22:43 ` H. Peter Anvin
2008-09-11 23:16 ` Alain Knaff
2008-09-11 23:21 ` H. Peter Anvin [this message]
2008-09-22 6:16 ` [update5] " Alain Knaff
2008-09-22 16:08 ` H. Peter Anvin
2008-09-22 16:15 ` Alain Knaff
2008-09-23 19:07 ` H. Peter Anvin
2008-09-23 19:44 ` Alain Knaff
2008-09-23 20:07 ` H. Peter Anvin
2008-09-23 21:07 ` H. Peter Anvin
2008-09-23 21:25 ` Alain Knaff
2008-09-23 21:30 ` H. Peter Anvin
2008-09-23 21:49 ` H. Peter Anvin
2008-09-23 22:00 ` Alain Knaff
2008-09-23 22:19 ` H. Peter Anvin
2008-09-23 22:23 ` Alain Knaff
2008-10-09 17:44 ` H. Peter Anvin
2008-10-10 3:11 ` Alain Knaff
2008-10-10 21:31 ` H. Peter Anvin
2008-10-11 7:28 ` Alain Knaff
2008-10-11 14:10 ` H. Peter Anvin
2008-10-13 7:02 ` Alain Knaff
2008-09-23 21:37 ` H. Peter Anvin
2008-09-24 3:52 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C9A80D.1010703@zytor.com \
--to=hpa@zytor.com \
--cc=alain@knaff.lu \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.