From: Jeff Garzik <jeff@garzik.org>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: netdev@vger.kernel.org, eric.miao@marvell.com, nico@cam.org
Subject: Re: [PATCH] smc91x: fix nowait printout
Date: Sat, 13 Sep 2008 15:12:55 -0400 [thread overview]
Message-ID: <48CC10B7.30504@garzik.org> (raw)
In-Reply-To: <20080908050256.11555.34058.sendpatchset@rx1.opensource.se>
Magnus Damm wrote:
> From: Magnus Damm <damm@igel.co.jp>
>
> Commit c4f0e76747e80578a8f7fddd82fd0ce8127bd2f8 added nowait platform
> data support. The printout code was however not updated, so the value
> of SMC_NOWAIT is still used. This patch makes sure that nowait is printed
> accordingly to platform data.
>
> Signed-off-by: Magnus Damm <damm@igel.co.jp>
> ---
>
> drivers/net/smc91x.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- 0001/drivers/net/smc91x.c
> +++ work/drivers/net/smc91x.c 2008-09-03 18:42:56.000000000 +0900
> @@ -1961,7 +1961,8 @@ static int __init smc_probe(struct net_d
> if (dev->dma != (unsigned char)-1)
> printk(" DMA %d", dev->dma);
>
> - printk("%s%s\n", nowait ? " [nowait]" : "",
> + printk("%s%s\n",
> + lp->cfg.flags & SMC91X_NOWAIT ? " [nowait]" : "",
> THROTTLE_TX_PKTS ? " [throttle_tx]" : "");
applied
prev parent reply other threads:[~2008-09-13 19:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 5:02 [PATCH] smc91x: fix nowait printout Magnus Damm
2008-09-13 19:12 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48CC10B7.30504@garzik.org \
--to=jeff@garzik.org \
--cc=eric.miao@marvell.com \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.