From: Jeff Garzik <jeff@garzik.org>
To: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
Cc: akpm@linux-foundation.org, netdev@vger.kernel.org,
chrisl@vmware.com, arvidjaar@mail.ru, "Allan,
Bruce W" <bruce.w.allan@intel.com>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"Ronciak, John" <john.ronciak@intel.com>,
"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>,
pratap@vmware.com, zach@vmware.com
Subject: Re: [patch for 2.6.27? 4/4] e1000e: prevent corruption of EEPROM/NVM
Date: Sat, 13 Sep 2008 15:15:02 -0400 [thread overview]
Message-ID: <48CC1136.2090005@garzik.org> (raw)
In-Reply-To: <36D9DB17C6DE9E40B059440DB8D95F52060519E7@orsmsx418.amr.corp.intel.com>
Brandeburg, Jesse wrote:
> akpm@linux-foundation.org wrote:
>> From: Christopher Li <chrisl@vmware.com>
>>
>> Andrey reports e1000e corruption, and that a patch in vmware's ESX
>> fixed
>> it.
>>
>> The EEPROM corruption is triggered by concurrent access of the EEPROM
>> read/write. Putting a lock around it solve the problem.
>>
>
> NAK. Please do not apply this patch, for reasons mentioned in my other
> reply just sent to netdev.
>
> The RTNL should be preventing this from being a possible bug in *Linux*
> and if it is not we have much larger problems, not the least of which is
> that this patch doesn't lock against the driver accessing the eeprom
> simultaneously.
Ping. A problem still occurs, regardless of what should be prevented?
next prev parent reply other threads:[~2008-09-13 19:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-02 21:48 [patch for 2.6.27? 4/4] e1000e: prevent corruption of EEPROM/NVM akpm
2008-09-02 22:01 ` Brandeburg, Jesse
2008-09-13 19:15 ` Jeff Garzik [this message]
2008-09-03 20:59 ` Kok, Auke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48CC1136.2090005@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=arvidjaar@mail.ru \
--cc=bruce.w.allan@intel.com \
--cc=chrisl@vmware.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=pratap@vmware.com \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.