From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: Bob Stewart <bob@evoria.net>, linux-ide@vger.kernel.org
Subject: Re: [PATCH #upstream-fixes] sata_inic162x: enable LED blinking
Date: Sat, 13 Sep 2008 16:43:40 -0400 [thread overview]
Message-ID: <48CC25FC.2030806@garzik.org> (raw)
In-Reply-To: <48C8E9CB.7040605@kernel.org>
Tejun Heo wrote:
> From: Bob Stewart <bob@evoria.net>
>
> Enable LED blinking.
>
> Signed-off-by: Bob Stewart <bob@evoria.net>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> ---
> The patch was wrapped. I reformatted a little bit.
>
> drivers/ata/sata_inic162x.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ata/sata_inic162x.c b/drivers/ata/sata_inic162x.c
> index 3ead02f..5032c32 100644
> --- a/drivers/ata/sata_inic162x.c
> +++ b/drivers/ata/sata_inic162x.c
> @@ -96,6 +96,7 @@ enum {
> PORT_SCR = 0x20,
>
> /* HOST_CTL bits */
> + HCTL_LEDEN = (1 << 3), /* enable LED operation */
> HCTL_IRQOFF = (1 << 8), /* global IRQ off */
> HCTL_FTHD0 = (1 << 10), /* fifo threshold 0 */
> HCTL_FTHD1 = (1 << 11), /* fifo threshold 1*/
> @@ -540,7 +541,7 @@ static unsigned int inic_qc_issue(struct ata_queued_cmd *qc)
> void __iomem *port_base = inic_port_base(ap);
>
> /* fire up the ADMA engine */
> - writew(HCTL_FTHD0, port_base + HOST_CTL);
> + writew(HCTL_FTHD0 | HCTL_LEDEN, port_base + HOST_CTL);
> writew(IDMA_CTL_GO, port_base + PORT_IDMA_CTL);
> writeb(0, port_base + PORT_CPB_PTQFIFO);
applied
prev parent reply other threads:[~2008-09-13 20:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 16:58 sata_inic162x echo6
2008-08-21 16:52 ` sata_inic162x Alan Cox
2008-08-21 18:00 ` sata_inic162x echo6
2008-08-30 10:29 ` sata_inic162x Tejun Heo
2008-09-04 0:35 ` sata_inic162x LED enable request Bob Stewart
2008-09-04 7:27 ` echo6
2008-09-04 15:54 ` Bob Stewart
2008-09-04 18:14 ` echo6
2008-09-04 8:13 ` Tejun Heo
2008-09-04 15:52 ` Bob Stewart
2008-09-08 12:12 ` Tejun Heo
2008-09-08 15:13 ` Bob Stewart
2008-09-08 19:09 ` Tejun Heo
2008-09-08 20:24 ` Bob Stewart
2008-09-09 7:53 ` Tejun Heo
2008-09-09 19:41 ` Bob Stewart
2008-09-11 9:50 ` [PATCH #upstream-fixes] sata_inic162x: enable LED blinking Tejun Heo
2008-09-13 20:43 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48CC25FC.2030806@garzik.org \
--to=jeff@garzik.org \
--cc=bob@evoria.net \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.