All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@nokia.com>
To: ext Hans Verkuil <hverkuil@xs4all.nl>
Cc: "Zutshi Vimarsh \(Nokia-D-MSW/Helsinki\)"
	<vimarsh.zutshi@nokia.com>,
	Linux and Kernel Video <video4linux-list@redhat.com>,
	Toivonen Tuukka Olli Artturi <tuukka.o.toivonen@nokia.com>
Subject: Re: [PATCH 0/7] V4L changes for OMAP 3 camera
Date: Mon, 15 Sep 2008 18:25:25 +0300	[thread overview]
Message-ID: <48CE7E65.1000301@nokia.com> (raw)
In-Reply-To: <200809082218.14332.hverkuil@xs4all.nl>

ext Hans Verkuil wrote:
> Hi Sakari,

Hello again, Hans!

(I'm removing Mohit since he's not involved with OMAP 3 camera driver 
anymore, as far as I understand.)

> Well, here they are:
> 
> Patch 1/7 seems to be missing in action. Can you post that one again?

Oops. I thought I posted this again but it hasn't appeared on the list.

I'll repost that soon.

> Patch 2/7: Acked-by: Hans Verkuil <hverkuil@xs4all.nl>
> 
> Patch 3/7: Acked-by: Hans Verkuil <hverkuil@xs4all.nl>
> 
> Patch 4/7: I'm having problems with this one. Shouldn't it be better to 
> make this a driver-private ioctl? And then that ioctl can actually 
> return a struct containing those settings, rather than a eeprom dump. 
> It is highly device specific, after all, so let the device extract and 
> return the useful information instead of requiring an application to do 
> that.

Laurent Pinchart suggested to make this available through sysfs. I guess 
this is what we'll do instead for now, at least, as I don't have enough 
information on different sensors and what they might have in their EEPROMs.

> Patch 5/7: Please add the explanation regarding possible transitions as 
> comments to the header. Also, why is the RESUME needed? You have three 
> states: off, standby, on. Resume is not a state, it is a state 
> transition. It seems out of place.

These are not actually states but commands. All except resume are also 
states. Maybe that's a bit confusing which is bad, I suppose. Anyway, 
this way the slave driver does not need to know its last power state as 
long as it supports these state transitions.

I'll add more documentation to v4l2-int-device.h.

> Patch 6/7: Acked-by: Hans Verkuil <hverkuil@xs4all.nl>
> 
> Patch 7/7: Acked-by: Hans Verkuil <hverkuil@xs4all.nl>

Great!

> Note: as I have stated in earlier posts, I'm not happy about having 
> multiple interfaces for sensors (soc-camera vs v4l2-int-device). 
> However, since there is no replacement available at the moment I'm not 
> going to hold back this effort.

Thanks.

(I'll try to pay more attention to v4l2_client and v4l-dvb-ng tree. :))

-- 
Sakari Ailus
sakari.ailus@nokia.com

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

  reply	other threads:[~2008-09-15 15:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-08 16:47 [PATCH 0/7] V4L changes for OMAP 3 camera Sakari Ailus
     [not found] ` <12208924933529-git-send-email-sakari.ailus@nokia.com>
2008-09-08 16:48   ` [PATCH 2/7] V4L: Int if: Add cropcap, g_crop and s_crop commands Sakari Ailus
2008-09-08 16:48     ` [PATCH 3/7] V4L: Add 10-bit RAW Bayer formats Sakari Ailus
2008-09-08 16:48       ` [PATCH 4/7] V4L: Add VIDIOC_G_PRIV_MEM ioctl Sakari Ailus
2008-09-08 16:48         ` [PATCH 5/7] V4L: Int if: Define new power state changes Sakari Ailus
2008-09-08 16:48           ` [PATCH 6/7] V4L: Int if: Export more interfaces to modules Sakari Ailus
2008-09-08 16:48             ` [PATCH 7/7] V4L: Int if: Add enum_framesizes and enum_frameintervals ioctls Sakari Ailus
2008-09-13 16:14         ` [PATCH 4/7] V4L: Add VIDIOC_G_PRIV_MEM ioctl Laurent Pinchart
2008-09-08 20:18 ` [PATCH 0/7] V4L changes for OMAP 3 camera Hans Verkuil
2008-09-15 15:25   ` Sakari Ailus [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-09-09  7:32 Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48CE7E65.1000301@nokia.com \
    --to=sakari.ailus@nokia.com \
    --cc=hverkuil@xs4all.nl \
    --cc=tuukka.o.toivonen@nokia.com \
    --cc=video4linux-list@redhat.com \
    --cc=vimarsh.zutshi@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.