From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Paul Menage <menage@google.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
Andrew Morton <akpm@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix declaration of cgroup_mm_owner_callbacks()
Date: Mon, 15 Sep 2008 11:51:38 -0700 [thread overview]
Message-ID: <48CEAEBA.10208@linux.vnet.ibm.com> (raw)
In-Reply-To: <B21AC749-D9D3-4B6C-B490-091F06F78E41@google.com>
Paul Menage wrote:
> +static inline void cgroup_mm_owner_callbacks(struct task_struct *old,
> + struct task_struct *new) {}
This is confusing coding style, I'd prefer to see the implementation after the
function declaration
Looks good to me otherwise.
--
Balbir
prev parent reply other threads:[~2008-09-15 18:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-15 18:41 [PATCH] Fix declaration of cgroup_mm_owner_callbacks() Paul Menage
2008-09-15 18:51 ` Balbir Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48CEAEBA.10208@linux.vnet.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.