From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 16 Sep 2008 11:44:35 +0100 (BST) Received: from h155.mvista.com ([63.81.120.155]:16959 "EHLO imap.sh.mvista.com") by ftp.linux-mips.org with ESMTP id S36918626AbYIPKoa (ORCPT ); Tue, 16 Sep 2008 11:44:30 +0100 Received: from [127.0.0.1] (unknown [10.150.0.9]) by imap.sh.mvista.com (Postfix) with ESMTP id E7DFE3ECD; Tue, 16 Sep 2008 03:44:25 -0700 (PDT) Message-ID: <48CF8E05.6050000@ru.mvista.com> Date: Tue, 16 Sep 2008 14:44:21 +0400 From: Sergei Shtylyov User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: roel kluin Cc: ralf@linux-mips.org, yoichi_yuasa@tripeaks.co.jp, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [MIPS] vr41xx: unsigned irq cannot be negative References: <48CF02EE.8050406@gmail.com> In-Reply-To: <48CF02EE.8050406@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 20503 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: sshtylyov@ru.mvista.com Precedence: bulk X-list: linux-mips Hello. roel kluin wrote: > unsigned irq cannot be negative > > Signed-off-by: Roel Kluin > --- > diff --git a/arch/mips/vr41xx/common/irq.c b/arch/mips/vr41xx/common/irq.c > index cba36a2..92dd1a0 100644 > --- a/arch/mips/vr41xx/common/irq.c > +++ b/arch/mips/vr41xx/common/irq.c > @@ -72,6 +72,7 @@ static void irq_dispatch(unsigned int irq) > cascade = irq_cascade + irq; > if (cascade->get_irq != NULL) { > unsigned int source_irq = irq; > + int ret; > Keep an empty line after the declaration block please. > @@ -79,8 +80,9 @@ static void irq_dispatch(unsigned int irq) > desc->chip->mask(source_irq); > desc->chip->ack(source_irq); > } > - irq = cascade->get_irq(irq); > - if (irq < 0) > + ret = cascade->get_irq(irq); > + irq = ret; > + if (ret < 0) > atomic_inc(&irq_err_count); > else > irq_dispatch(irq); > How about this: ret = cascade->get_irq(irq); if (ret < 0) atomic_inc(&irq_err_count); else irq_dispatch(ret); WBR, Sergei