All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] help git-upload-pack find git
Date: Tue, 16 Sep 2008 15:43:54 +0200	[thread overview]
Message-ID: <48CFB81A.5060108@viscovery.net> (raw)
In-Reply-To: <48CFB183.1090205@drmicha.warpmail.net>

Michael J Gruber schrieb:
> Why is it that setup_path() cannot be done before commit_pager_choice()?
> We need the pager in case list_common_cmds_help() is triggered, but why
> can't setup_path() be before that? Not because of "--", really.

I think that setup_path() must be called *after* handle_options() because
of this use-case:

  $ git --exec-path=/some/where foo

and git_set_argv0_path() must be called *before* handle_options() because
of this use-case:

  $ git --exec-path

-- Hannes

  reply	other threads:[~2008-09-16 13:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-10  2:29 git-clone: path or ssh problem with git-upload-pack in 1.6.0? Paul Johnston
2008-09-15  8:30 ` Paul Johnston
2008-09-15 16:24   ` [PATCH] help git-upload-pack find git Michael J Gruber
2008-09-15 19:34     ` Junio C Hamano
2008-09-15 20:22       ` Michael J Gruber
2008-09-16  6:17         ` Johannes Sixt
2008-09-16 13:15           ` Michael J Gruber
2008-09-16 13:43             ` Johannes Sixt [this message]
2008-09-16 15:38               ` Michael J Gruber
2008-09-15 16:25   ` git-clone: path or ssh problem with git-upload-pack in 1.6.0? Michael J Gruber
2008-09-15 22:39 ` Michael Wookey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48CFB81A.5060108@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.