From: Zhigang Wang <zhigang.x.wang@oracle.com>
To: xen-devel <xen-devel@lists.xensource.com>
Subject: [PATCH]Fix wrong data type in xc_save.c
Date: Wed, 17 Sep 2008 20:53:18 +0800 [thread overview]
Message-ID: <48D0FDBE.7000307@oracle.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 183 bytes --]
Fix wrong data type in xc_save.c. xc_interface_open() may return -1, if we
define xc_fd as unsigned int, then -1 will be > 0.
Signed-off-by: Zhigang Wang <zhigang.x.wang@oracle.com>
[-- Attachment #2: xen-xc-save.patch --]
[-- Type: text/x-patch, Size: 499 bytes --]
--- xen-unstable/tools/xcutils/xc_save.c 2008-09-10 01:02:42.000000000 +0800
+++ xen-unstable.local/tools/xcutils/xc_save.c 2008-09-17 17:41:42.000000000 +0800
@@ -297,8 +297,8 @@ static void *init_qemu_maps(int domid, u
int
main(int argc, char **argv)
{
- unsigned int xc_fd, io_fd, domid, maxit, max_f, flags;
- int ret;
+ unsigned int domid, maxit, max_f, flags;
+ int xc_fd, io_fd, ret;
if (argc != 6)
errx(1, "usage: %s iofd domid maxit maxf flags", argv[0]);
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
reply other threads:[~2008-09-17 12:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D0FDBE.7000307@oracle.com \
--to=zhigang.x.wang@oracle.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.