From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Zev Weiss <zevweiss@gmail.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] [MTD] physmap.c: Check return of platform_device_register()
Date: Wed, 17 Sep 2008 23:43:04 +0400 [thread overview]
Message-ID: <48D15DC8.60307@ru.mvista.com> (raw)
In-Reply-To: <20080917115746.e36cacc6.akpm@linux-foundation.org>
Hello.
Andrew Morton wrote:
>>The PHYSMAP_COMPAT code had been ignoring the return value of
>>platform_device_register() in the physmap_init() function.
>>Signed-off-by: Zev Weiss <zevweiss@gmail.com>
[...]
>>diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
>>index 42d844f..6fba0d4 100644
>>--- a/drivers/mtd/maps/physmap.c
>>+++ b/drivers/mtd/maps/physmap.c
>>@@ -312,7 +312,7 @@ static int __init physmap_init(void)
>> err = platform_driver_register(&physmap_flash_driver);
>> #ifdef PHYSMAP_COMPAT
>> if (err == 0)
>>- platform_device_register(&physmap_flash);
>>+ err = platform_device_register(&physmap_flash);
>> #endif
>>
>> return err;
> Your email client is performing space-stuffing, thus making the patches
> unapplyable.
Er... are you sure? The patch looks alright tab wise, even after quoting...
> Presumably we should run platform_driver_unregister() if the
> platform_device_register() failed.
Why is that? There could be "normal" platform devices out there...
WBR, Sergei
next prev parent reply other threads:[~2008-09-17 19:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-13 6:32 [PATCH 1/3] [MTD] physmap.c: Check return of platform_device_register() Zev Weiss
2008-09-13 10:45 ` Lennert Buytenhek
2008-09-13 11:27 ` Zev Weiss
2008-09-17 18:57 ` Andrew Morton
2008-09-17 19:43 ` Sergei Shtylyov [this message]
2008-09-17 19:46 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D15DC8.60307@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=zevweiss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.