From: Milan Broz <mbroz@redhat.com>
To: device-mapper development <dm-devel@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>, Alasdair G Kergon <agk@redhat.com>
Subject: Re: Barrier support in device mapper
Date: Thu, 18 Sep 2008 08:57:02 +0200 [thread overview]
Message-ID: <48D1FBBE.4080305@redhat.com> (raw)
In-Reply-To: <200809181127.37704.knikanth@suse.de>
Nikanth Karthikesan wrote:
> Are we going to get full-barrier support soon? If not, I would like to see
> Andi's patch being merged till we get full barrier support ready. I would like
> to know your thoughts.
Hi,
Andi's patch is not complete and I think there can be several problems with it:
- imagine DM device which has barrier support switched on by this simple patch and
you try to run pvmove on it. How is the barrier request processed by underlying
devices now?
-> mapping can change online (pvmove, lvextend, lvconvert, ...) to more
complicated mapping - who reset barrier flag support?
- what about stacking devices? Imagine crypto - there is one device per
table possible under linear target (where you enable barriers by this patch).
dm-crypt will need to implement some queue flushes to properly support
barriers. Another example - partition mapping over multipath (kpartx), ...
Are you sure that is it safe with Andi's patch?
...
It is dangerous to use that patch IMO, better not support barriers at all here.
That's why we need something more robust.
Unfortunately I received _no_ feedback to mentioned RFC barrier patches.
Milan
--
mbroz@redhat.com
next prev parent reply other threads:[~2008-09-18 6:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-18 5:57 Barrier support in device mapper Nikanth Karthikesan
2008-09-18 6:57 ` Milan Broz [this message]
2008-09-18 13:44 ` Andi Kleen
2008-09-18 16:08 ` Milan Broz
2008-09-18 18:13 ` Andi Kleen
2008-09-18 18:34 ` Milan Broz
2008-09-18 18:53 ` Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2008-09-18 10:16 Nikanth Karthikesan
2008-09-18 13:47 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D1FBBE.4080305@redhat.com \
--to=mbroz@redhat.com \
--cc=agk@redhat.com \
--cc=andi@firstfloor.org \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.