From: Sebastian Siewior <bigeasy@linutronix.de>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] i2c: add support for MAX1618 in MAX1619
Date: Thu, 18 Sep 2008 08:12:31 +0000 [thread overview]
Message-ID: <48D20D6F.9000705@linutronix.de> (raw)
In-Reply-To: <20080916133542.GA2072@www.tglx.de>
Jean Delvare wrote:
> Hi Sebastian,
>
> Your patch is way too big for what it is doing. All you really need
> to do to have MAX1618 support is prevent the driver from creating the
> temp1* files in sysfs for this chip. This can be done very easily by
> having two attribute groups, one for temp1 and one for temp2.
Thanks for the review. I try address your issues but it may take some time.
Sebastian
--
Firmensitz: 88690 Uhldingen, Auf dem Berg 3
Registergericht: Amtsgericht Freiburg i. Br., HRB 700 806;
StNr. 87007/07777; Ust-Id Nr.: DE252739476
Geschäftsführer: Heinz Egger, Thomas Gleixner
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2008-09-18 8:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-16 13:35 [lm-sensors] [PATCH] i2c: add support for MAX1618 in MAX1619 driver Sebastian Siewior
2008-09-16 17:29 ` [lm-sensors] [PATCH] i2c: add support for MAX1618 in MAX1619 Jean Delvare
2008-09-16 17:32 ` Jean Delvare
2008-09-17 22:08 ` Andrew Morton
2008-09-18 8:12 ` Sebastian Siewior [this message]
2008-09-28 16:02 ` Jean Delvare
2008-09-28 22:42 ` Andrew Morton
2008-09-29 8:04 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D20D6F.9000705@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.