Re: [PATCH 1/5] HID: move pantherlord FF processing

[Jiri Slaby <jirislaby@gmail.com>]

On 09/17/2008 07:03 PM, Jiri Kosina wrote:
> On Thu, 4 Sep 2008, Jiri Slaby wrote:
> 
>> Move the force feedback precessing into a separate module.
>>
>> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> 
>> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
>> index 0784a09..a4d9695 100644
>> --- a/drivers/hid/hid-ids.h
>> +++ b/drivers/hid/hid-ids.h
>> @@ -373,6 +373,8 @@
>>  #define USB_DEVICE_ID_QUAD_USB_JOYPAD	0x8800
>>  #define USB_DEVICE_ID_DUAL_USB_JOYPAD	0x8866
>>  
>> +#define USB_VENDOR_ID_GREENASIA		0x0e8f
>> +
>>  #define USB_VENDOR_ID_WISEGROUP_LTD	0x6666
>>  #define USB_VENDOR_ID_WISEGROUP_LTD2	0x6677
>>  #define USB_DEVICE_ID_SMARTJOY_DUAL_PLUS 0x8802
> 
> Could we please preserve alphabetical ordering in hid-ids.h file?

Oops, sorry for that, I tried to sort it numerically not noticing it's sorted
alphabetically.

> Otherwise the series looks good to me, and Anssi didn't complain as well. 
> Could you please rebase it on top of the current HID tree, fix the 
> ordering, and send it to me again, I will apply it?

No problem.

Thanks.