All of lore.kernel.org
 help / color / mirror / Atom feed
From: Uri Lublin <uril@qumranet.com>
To: "Hacking, Stuart" <stuart.hacking@sap.com>
Cc: kvm@vger.kernel.org
Subject: Re: Problem adding new source files
Date: Thu, 18 Sep 2008 16:18:28 +0300	[thread overview]
Message-ID: <48D25524.7060601@qumranet.com> (raw)
In-Reply-To: <43BCF5BD5ADA674C839A0242AC72B32B01244BCD@dewdfe1f.wdf.sap.corp>

Hacking, Stuart wrote:
> Hello,
Hi,
>  
> We have been doing some experimentation with modifications to the
> migration code in the Qemu and came up against a problem.  We included
> some code in a different file and are receiving the following error from
> make:
>  
> ---
> Migration.o: In function `migrate_prepare_page':
> /root/tmp/KVM/qemu/migration.c:367: undefined reference to
> `get_cached_page'
> /root/tmp/KVM/qemu/migration.c:367: undefined reference to
> `get_cached_page'
> /root/tmp/KVM/qemu/migration.c:367: undefined reference to
> `get_cached_page'
> collect2: ld returned 1 exit status
> Make[2]: *** [qemu-system_x86_64] Error 1
> Make[1]: *** [subdir-x86_64-softmmu] Error2
> Make: *** [qemu] Error 2
> ---

Did you define new functions in a different .c file(s) ? Did you provide 
prototypes for all new functions ? Did you add all new files to the Makefile ?

> 
> We see from looking at the code that everything seems to be correct and
> we suspect that the error is coming from the order that the files are
> being compiled.  Is there any special consideration we need to take when
> adding new headers and code files to the tree?  (at the minute any new
> files we added are in the same directory as migration.c.)
>  
> We aren't sure if the kvm maintainers are using a custom makefile,
> however, would it be more appropriate to post this on the Qemu mailing
> list?
Speculations...
I'm sure kvm maintainer and developers (and users) use the released Makefile.

Regards,
Uri.

  reply	other threads:[~2008-09-18 13:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-18 11:56 Problem adding new source files Hacking, Stuart
2008-09-18 13:18 ` Uri Lublin [this message]
2008-09-18 15:09   ` Hacking, Stuart
2008-09-18 16:01     ` Uri Lublin
2008-09-19 13:23       ` Hacking, Stuart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48D25524.7060601@qumranet.com \
    --to=uril@qumranet.com \
    --cc=kvm@vger.kernel.org \
    --cc=stuart.hacking@sap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.