From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Kga3v-0003d9-MJ for mharc-grub-devel@gnu.org; Fri, 19 Sep 2008 03:05:55 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kga3s-0003bm-Mc for grub-devel@gnu.org; Fri, 19 Sep 2008 03:05:52 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kga3q-0003aC-Un for grub-devel@gnu.org; Fri, 19 Sep 2008 03:05:52 -0400 Received: from [199.232.76.173] (port=52226 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kga3q-0003a6-OS for grub-devel@gnu.org; Fri, 19 Sep 2008 03:05:50 -0400 Received: from mx20.gnu.org ([199.232.41.8]:25210) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Kga3p-0000PF-VN for grub-devel@gnu.org; Fri, 19 Sep 2008 03:05:50 -0400 Received: from mailout08.t-online.de ([194.25.134.20]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kga3n-0003PY-Rm for grub-devel@gnu.org; Fri, 19 Sep 2008 03:05:48 -0400 Received: from fwd01.aul.t-online.de by mailout08.sul.t-online.de with smtp id 1Kga3k-00046y-02; Fri, 19 Sep 2008 09:05:44 +0200 Received: from [10.3.2.2] (VmlGPBZeZhPaXSWpWIu5XyhhltuHlCtw36A1sUgtYxkz+0MR-AgxdJ1inC757iFgIP@[217.235.206.222]) by fwd01.aul.t-online.de with esmtp id 1Kga3U-0TzhlA0; Fri, 19 Sep 2008 09:05:28 +0200 Message-ID: <48D34F38.6040504@t-online.de> Date: Fri, 19 Sep 2008 09:05:28 +0200 From: Christian Franke User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.16) Gecko/20080702 SeaMonkey/1.1.11 MIME-Version: 1.0 To: The development of GRUB 2 References: <48D00C3A.9000804@t-online.de> <20080917135844.GB23010@thorin> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ID: VmlGPBZeZhPaXSWpWIu5XyhhltuHlCtw36A1sUgtYxkz+0MR-AgxdJ1inC757iFgIP X-TOI-MSGID: 5d476abe-d149-4409-8c0e-4b90d17e3869 X-detected-kernel: by mx20.gnu.org: Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH] Add __enable_execute_stack() if required X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Sep 2008 07:05:53 -0000 walt wrote: > Robert Millan wrote: >> On Tue, Sep 16, 2008 at 09:42:50PM +0200, Christian Franke wrote: >>> Some gcc versions generate a call to __enable_execute_stack() in >>> trampolines for nested functions. This is the case for new Cygwin >>> gcc-4.3.2. >>> >>> Other GRUB2 target platforms may be affected - the following files in >>> 'gcc-4.3.2/gcc/config' source directory contains implementations of >>> this >>> function for libgcc: >>> >>> alpha/osf.h >>> darwin.h >>> netbsd.h >> >> I recall this was also an issue for NetBSD indeed. Could someone >> confirm it >> fixes the problem there? > > It does fix the problem on NetBSD, thanks Christian. > You're welcome. Thanks for testing. Patch committed. If more such functions are necessary in the future, it is probably better to collect those in some libgcc.a replacement module. This would be the case if e.g. for the 64-bit integer division. On 32-bit architectures, gcc typically generates a call to __divdi3(). Christian