From: Jiri Moravec <jim.lkml@gmail.com>
To: netfilter-devel@vger.kernel.org
Subject: [PATCH] xtables-addons: Missing reference operator in xt_ECHO.c (for Jan Engelhardt)
Date: Fri, 19 Sep 2008 22:28:37 +0200 [thread overview]
Message-ID: <48D40B75.2030407@gmail.com> (raw)
Jan,
when you prepared commit ab27472eb44b0690f74d542ddb9a972460eceb9a, you probably overlooked some piece of code, because my gcc objects:
"2.6.26.5-t4/net/netfilter/xtables-addons/xt_ECHO.c:90: warning: passing argument 1 of ‘xtnu_ip_route_me_harder’ from incompatible pointer type"
diff -Nupr old/extensions/xt_ECHO.c new/extensions/xt_ECHO.c
--- old/extensions/xt_ECHO.c 2008-09-19 19:04:37.000000000 +0200
+++ new/extensions/xt_ECHO.c 2008-09-19 19:05:00.000000000 +0200
@@ -87,7 +87,7 @@ static unsigned int echo_tg4(struct sk_b
dst_hold(oldskb->dst);
newskb->dst = oldskb->dst;
- if (ip_route_me_harder(newskb, addr_type) < 0)
+ if (ip_route_me_harder(&newskb, addr_type) < 0)
goto free_nskb;
newip->ttl = dst_metric(newskb->dst, RTAX_HOPLIMIT);
--
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2008-09-19 21:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-19 20:28 Jiri Moravec [this message]
2008-09-19 23:04 ` [PATCH] xtables-addons: Missing reference operator in xt_ECHO.c (for Jan Engelhardt) Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D40B75.2030407@gmail.com \
--to=jim.lkml@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.