From: Mark Goodwin <markgw@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: lachlan@sgi.com, xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] Remove xfs_iext_irec_compact_full()
Date: Mon, 22 Sep 2008 14:14:21 +1000 [thread overview]
Message-ID: <48D71B9D.2040800@sgi.com> (raw)
In-Reply-To: <48D71701.6070900@sandeen.net>
Eric Sandeen wrote:
> Lachlan McIlroy wrote:
>> Yet another bug was found in xfs_iext_irec_compact_full() and while the
>> source of the bug was found it wasn't an easy task to track it down because
>> the conditions are very difficult to reproduce. Code that is difficult to
>> reach is difficult to test and debug.
>
> It might be nice to give credit to those who helped find it in the commit ;)
yes, this is a very significant bug to find, thanks.
I'm wondering whether it would be worth auditing or re-reviewing the entire
incore-extents-optimization patchset (if that's possible against the current
code base). Or should we just fix this and move on - let the testing
speak for
itself? The hard to hit code paths are a worry IMO.
Cheers
-- Mark
next prev parent reply other threads:[~2008-09-22 4:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-22 3:50 [PATCH] Remove xfs_iext_irec_compact_full() Lachlan McIlroy
2008-09-22 3:54 ` Eric Sandeen
2008-09-22 4:14 ` Mark Goodwin [this message]
2008-09-22 4:25 ` Lachlan McIlroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D71B9D.2040800@sgi.com \
--to=markgw@sgi.com \
--cc=lachlan@sgi.com \
--cc=sandeen@sandeen.net \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.